[Laszlo-dev] For Review: Change 20090227-ptw-e Summary: Correct implementation of LzText/getTextSize

[André Bargull]

Approved (with the necessary changes to lztest-textheight.lzx, as 
outlined by Max).

So for the record:
LzView#getTextHeight() delegates to LzSprite#getTextfieldHeight() which 
returns the height of the text (with the 2px flash-gutter). Right?


On 2/27/2009 9:05 PM, P T Withington wrote:
> Change 20090227-ptw-e by ptw at dueling-banjos.home on 2009-02-27 
> 14:50:27 EST
>     in /Users/ptw/OpenLaszlo/trunk-3
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Correct implementation of LzText/getTextSize
>
> Bugs Fixed: LPP-7569  Text in scrolledittext flips after 13 characters.
>
> Technical Reviewer: a.bargull at intensis.de, max (pending)
> QA Reviewer: aalappat at laszlosystems.com (pending)
>
> Details:
>     *: Note LPP-7832
>
>     LzInputTextSprite.as: Remove incorrect override of
>     getTextfieldHeight
>
>     LzText: call correct kernel API
>
> Tests:
>     Test case from bug report, smokecheck, sample apps
>
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
> M      WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as
> M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
> M      WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
> M      WEB-INF/lps/lfc/kernel/swf9/LzInputTextSprite.as
> M      WEB-INF/lps/lfc/views/LzText.lzs
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090227-ptw-e.tar
>