[Laszlo-dev] For Review: Change 20090225-dda-V Summary: do not drop 'void' return types

[Donald Anderson]

Change 20090225-dda-V by dda at lester-2.local on 2009-02-25 16:39:47 EST
     in /Users/dda/laszlo/src/svn/openlaszlo/trunk-b
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: do not drop 'void' return types

New Features:

Bugs Fixed: [LPP-7789] SWF9: void return-type dropped

Technical Reviewer: ptw (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
   Parser.jjt
     Fixed a mistake that was setting the return type in the AST to  
null for any function declared as "void".
     Null really means 'no return type specified' and must be  
distinguished from simply "void".
     "void" is now set as the return type in the AST.  Since this  
effectively 'enables' :void
     return types to appear in SWF9, this gave a small ripple effect  
in the lfc as detailed below.

   LzReplicationManager.lzs
   LzDatapointer.lzs
   LzDatapath.lzs
     for override functions destroy(), construct(), setSelected(), $lzc 
$set_datapath(),
     the :void return type has been removed to be compatible with the  
function it overrides.
     This amounts to no change for anyone calling or overriding these  
functions,
     given that the bug's previous behavior was to effectively  
remove :void

   services/LzBrowser.lzs
     according to the doc callJS() 'optionally' returns a value (the  
DHTML version does), so its :void
     return type has been removed.  Again, no discernable change to  
the user, and it now matches its
     documentation.

   LzDataSelectionManager.lzs
   LzSelectionManager.lzs
     public functions unselect(),clearSelection(),select() now  
have :void return type removed.
     Some of these may be overridden (without return types) by  
components.

   swf9/LzDebug.as
   swf/LzDebug.as
     added :void to displayResult() to match LzDebugService.  This  
function is marked private in doc,
     so users should not be overriding this, and should be unaware of  
the change.

   LaszloView.lzs
   LaszloCanvas.lzs
     added :void to __LZinstantiationDone() to match LzNode.  This  
function is also marked private in doc,
     so users should not be overriding this, and should be unaware of  
the change.

   ParseTreePrinter.java
     Fixed an informational message triggered by the -SS flag to lzc,  
so the exact filename generated for
     for debugging line annotations is shown.


Tests:
     Andre's test case now gives the proper error message.

     {smokecheck,weather,lzpix} x {swf8,swf9,dhtml}

Files:
M      WEB-INF/lps/lfc/services/LzBrowser.lzs
M      WEB-INF/lps/lfc/debugger/platform/swf/LzDebug.as
M      WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
M      WEB-INF/lps/lfc/views/LaszloView.lzs
M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M      WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
M      WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
M      WEB-INF/lps/lfc/data/LzReplicationManager.lzs
M      WEB-INF/lps/lfc/data/LzDatapointer.lzs
M      WEB-INF/lps/lfc/data/LzDatapath.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090225-dda-V.tar



--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-306-2057
email: dda at ddanderson.com
www: http://www.ddanderson.com





-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20090226/730d45d2/attachment-0001.html