[Laszlo-dev] For Review: Change 20090224-bargull-clG Summary: presentation type attribute coercion breaks opttree

André Bargull andre.bargull at udo.edu
Tue Feb 24 07:47:57 PST 2009


Just made you the reviewer because the bug was caused by the 
ExpressionPresentationType changes.


Change 20090224-bargull-clG by bargull at dell--p4--2-53 on 2009-02-24 15:27:14
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: presentation type attribute coercion breaks opttree

New Features:

Bugs Fixed: LPP-7803 (opttree example doesn't work)

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
baseopttreenode.lzx:
- "dopen" attribute-type wasn't specified so ExpressionPresentationType 
coerced the value to a boolean
-> this broke the constraint for "open" which expected a string value
I've changed the attribute-type for "dopen" to boolean just to reduce 
possible (?) confusion
- "ddepth" same story as for "dopen", just replace boolean with number...
- also added "checkChildren" method which is expected in opttree 
("beginDrag" and "endDrag")

opttree.lzx:
- call "clearSelection()" instead of "select(null)" to clear the current 
selection (otherwise a nullptr exception was thrown in 
lz.dataselectionmanager)

treenode.lzx:
- only select node when clicked, not when the "open" attribute changed

test.lzx:
- override "select()" in order to provide the expected "selection" attribute



Tests:
run opttree test application

Files:
M lps/components/incubator/test/opttree/treenode.lzx
M lps/components/incubator/test/opttree/test.lzx
M lps/components/incubator/opttree/baseopttreenode.lzx
M lps/components/incubator/opttree/opttree.lzx

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20090224-bargull-clG.tar



More information about the Laszlo-dev mailing list