[Laszlo-dev] For Review: Change 20090218-maxcarlson-P Summary: UPDATED: Fix contextmenus for text, clickable views and offset views

[André Bargull]

In this testcase, if you right click on the blue view the contextmenu 
for the red view shows up in dhtml, this doesn't happen in swf8/swf9.

<canvas debug="true">
   <view width="100" height="100" bgcolor="red">
     <contextmenu>
       <contextmenuitem caption="foo" />
     </contextmenu>
   </view>
   <view width="100" height="100" bgcolor="blue"/>
</canvas>

[btw, I wonder if it's possible at all to get a proper cross-runtime 
behaviour for context menus.]

And one question: What do you mean here?
   "// window.oncontextmenu still isn't sent :("
(that's from LzSprite.prototype.__mouseEvent)

Otherwise approved.


On 2/18/2009 9:38 AM, Max Carlson wrote:
> Change 20090218-maxcarlson-P by maxcarlson at Bank.lan on 2009-02-18 
> 00:23:11 PST
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: UPDATED: Fix contextmenus for text, clickable views and offset 
> views
> 
> Bugs Fixed: LPP-7661 - Views without bgcolor allow context menus to 
> receive clicks in SWF but not in DHTML
> 
> Technical Reviewer: andre.bargull at udo.edu
> QA Reviewer: promanik
> 
> Release Notes:
> 
> Details:
> LzSprite, LzTextSprite, LzInputTextSprite - Rename __LZclickdiv to the 
> more descriptive __LZclickcontainerdiv.
> 
> LzSprite - Show context menus when clickable sprites get an onmousedown 
> event with event.button == 2 (the context button).  If a context menu is 
> set, resize the clickdiv container or scrolldiv (if present) to the 
> correct width/height.
> 
> LzTextSprite - Set owner property of scrolldiv so context menus work.
> 
> LzMouseKernel - Move context menu handling to __showContextMenu().  Walk 
> up the sprite hierarchy looking for sprites with a context menu that 
> have the mouse over them.  If found, show the context menu.
> 
> LzInputTextSprite - Set owner property of scrolldiv so context menus 
> work.  Update mouse position from text events, if available.  Show 
> context menus when  sprites get an onmousedown event with event.button 
> == 2 (the context button).
> 
> Tests: See LPP-7661.
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090218-maxcarlson-P.tar
>