[Laszlo-dev] For Review: Change 20090216-dda-V Summary: SWF9: Fix comma separated global declaration

[Donald Anderson]

Change 20090216-dda-V by dda at lester-2.local on 2009-02-16 12:11:27 EST
     in /Users/dda/laszlo/src/svn/openlaszlo/trunk-b
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: SWF9: Fix comma separated global declaration

New Features:

Bugs Fixed: [LPP-7746] SWF9: comma separated global var declarations  
don't compile

Technical Reviewer: ptw (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
     In SWF9, a variable statement that appears outside a method (that  
is, a global var declaration),
     is dismantled as the variable declaration appears in a separate  
file named for the global variable,
     e.g. var foo, bar ==> foo.as, bar.as
     The original variable expressions are left behind as empty  
expressions.
     This changeset fixes the unparser so it knows to drop empty  
expressions in a variable declaration list.
     This was not noticed testing with single variables 'var foo', as  
the unparser generated a comma separated
     list of expressions - one blank expression, comma separated,  
still yielded a blank result.

Tests:
     The test case from the JIRA now compiles.  Same test case with  
mix of initialized and uninitialized vars compiles.
     The usual regression tests: smokecheck, lzpix, weather on  
swf9,swf8,dhtml

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090216-dda-V.tar



--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-306-2057
email: dda at ddanderson.com
www: http://www.ddanderson.com





-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20090216/4a198902/attachment.html