[Laszlo-dev] For Review: Change 20090206-maxcarlson-Q Summary: Fix runtime setMultiline() and scrolledittext sizing in DHTML

[Max Carlson]

Sometimes you have to use div.setAttribute - usually when creating the 
tag/HTML for the first time.  In most cases, you can assign a property 
directly with script.

P T Withington wrote:
> And we have to use div.setAttribute?  We seem to sometimes use that, 
> othertimes just assign directly to the attribute.
> 
> On 2009-02-07, at 22:52EST, Max Carlson wrote:
> 
>> It prevents the compiler from rewriting div.setAttribute()...
>>
>> P T Withington wrote:
>>> Looks good.  Approved.
>>> Remind me again what lz.embed.__setAttr does for us?
>>> On 2009-02-06, at 09:55EST, Max Carlson wrote:
>>>> Change 20090206-maxcarlson-Q by maxcarlson at Bank.local on 2009-02-06 
>>>> 06:43:58 PST
>>>>   in /Users/maxcarlson/openlaszlo/trunk-clean
>>>>   for http://svn.openlaszlo.org/openlaszlo/trunk
>>>>
>>>> Summary: Fix runtime setMultiline() and scrolledittext sizing in DHTML
>>>>
>>>> Bugs Fixed: LPP-6580  scrolledittext doesn't work in 4.1 (partial), 
>>>> LPP-7726 - DHTML: setMultiline() has no effect after init time
>>>>
>>>> Technical Reviewer: ptw
>>>> QA Reviewer: hminsky
>>>>
>>>> Documentation: LzInputTextSprite - Refactor inputtext div 
>>>> initialization to separate method, call when creating an inputtext, 
>>>> or when the multiline state changes in setMultiline().  Update the 
>>>> field size metrics onkeypress.
>>>>
>>>> scrolledittext - Use constraints instead of applyConstraintMethod() 
>>>> for maintaining height/width.
>>>>
>>>> scrolledittext-test - Uncomment second scrolledittext, use default 
>>>> scrollbar class to test functionality.
>>>>
>>>> Details: This makes scrolledittext begin working in DHTML, with some 
>>>> issues.  Sometimes, the scroll attribute assertion is triggered, and 
>>>> maxscroll doesn't seem to be tall enough.  Also, typing carriage 
>>>> returns into the inputtext doesn't cause it to automatically scroll 
>>>> down when typing into the bottom of the field like it does with 
>>>> native scrollbars - the scrollTop/scroll doesn't change.  I'm not 
>>>> sure how to fix this because AFAIK there's no way to accurately 
>>>> figure out the cursor pixel offset when typing and set it manually - 
>>>> maybe Tucker has a clue...
>>>>
>>>> Tests: scrolledittext-test runs as before in swf8/9, and now 
>>>> (almost) works in DHTML.
>>>>
>>>> Files:
>>>> M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
>>>> M      lps/components/incubator/scrolledittext.lzx
>>>> M      lps/components/incubator/test/scrolledittext-test.lzx
>>>>
>>>> Changeset: 
>>>> http://svn.openlaszlo.org/openlaszlo/patches/20090206-maxcarlson-Q.tar
>>
>> -- 
>> Regards,
>> Max Carlson
>> OpenLaszlo.org
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org