[Laszlo-dev] For Review: Change 20090210-lou-e Summary: add support for user comments in docs

[Donald Anderson]

I think you might have to back out Henry's change to check this in (?),
I couldn't apply the changeset successfully in the current tree.  I  
agree with Henry,
let's get it in so we can all easily look at it in the overnight build.

In this part of the change:
+    <xsl:param name="prev" select="/foo"/>
+    <xsl:param name="next" select="/foo"/>

what is the purpose of selecting foo?

+                  <xsl:text>&#160;</xsl:text>

&#160;  is probably clearer as &nbsp;

I'm guessing this code was copied from somewhere docbook in order to  
override it?
If so, it would be good to state where it came from and mark the  
extent of the copied part.
Even better would be to figure out how to insert without copying, I  
don't know how to do that offhand.

- Don

On Feb 10, 2009, at 8:56 AM, Lou Iorio wrote:

> Change 20090210-lou-e by lou at loumac.local on 2009-02-10 09:50:46 AST
>    in /Users/lou/src/svn/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: add support for user comments in docs
>
> Technical Reviewer: henry
> QA Reviewer: don
> Doc Reviewer: (pending)
>
> Details: This is Henry's change, modified to move the comment to the
> end of the page. Comment from his changeset:
>
> + Added new flag in docs/src/xsl/parameters.xsl, show.usercomments
>
> <!-- Add link for display/submission of user community comments -->
> <xsl:param name="show.usercomments">1</xsl:param>
>
> When enabled, this adds in a user comments link at the bottom of each
> doc page, via the common-html.xsl user.footer.content template.
>
> The page docs/includes/commentwidget.js can be configured to point to
> the server which supplies the comments. If the server is unavailable,
> the comments will silently be omitted from the page.
>
> Tests: visual verify
>
> Files:
> A      docs/includes/commentwidget.js
> M      docs/src/xsl/common-html.xsl
> M      docs/src/xsl/parameters.xsl
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090210-lou-e.tar


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-306-2057
email: dda at ddanderson.com
www: http://www.ddanderson.com





-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20090210/764b0c5f/attachment.html