[Laszlo-dev] For Review: Change 20090203-dda-4 Summary: for catcherrors=true, conditionally generate call to reportExceptions based on $debug.

[P T Withington]

I assume the contract of CATCH_FUNCTION_EXCEPTIONS is to blunder on in  
the face of an error when there is no debugger?

If so, Approved!

On 2009-02-03, at 13:46EST, Donald Anderson wrote:

> Change 20090203-dda-4 by dda at lester-2.local on 2009-02-03 13:21:14 EST
>    in /Users/dda/laszlo/src/svn/openlaszlo/trunk-g
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: for catcherrors=true, conditionally generate call to  
> reportExceptions based on $debug.
>
> New Features:
>
> Bugs Fixed: LPP-7710 [errors when compiler.swf9.catcherrors=true and  
> runtime target = swf9]
>
> Technical Reviewer: ptw (pending)
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>    ** Changeset made against trunk - this is for consideration for  
> 4.2.0.1 (as well as 4.2.1).
>
>    We previously generated in the catch block:
>      if ($debug) { $lzsc$runtime.reportException(...); }
>    and this generated code did not get processed by the runtime  
> constant handler.
>    Since we don't have a non-debug version of the $lzsc$runtime  
> class, this comes up undefined.
>    Fix is to just not generate this code if debug is off.
>
> Tests:
>    With catcherrors=true:
>      Test case in LPP-7710, with/without debug set on canvas.
>      Test case in LPP-7514, with/without debug set in URL
>    With catcherrors=false:
>      {smokecheck,lzpix} x {swf8,swf9,dhtml}
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> JavascriptGenerator.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090203-dda-4.tar
>
>
>
> --
>
> Don Anderson
> Java/C/C++, Berkeley DB, systems consultant
>
> voice: 617-306-2057
> email: dda at ddanderson.com
> www: http://www.ddanderson.com
>
>
>
>
>