[Laszlo-dev] For Review: Summary: Fix radio button in incubator. Change 20090201-Philip-0

[Philip Romanik]

Change 20090201-Philip-0 by Philip at Philip-DC on 2009-02-01 18:23:44 EST
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix radio button in incubator

New Features:

Bugs Fixed: LPP-7698

Technical Reviewer: henry
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
The last change to the incubator changed a method name from setValue 
to doSetValue. The problem is that setValue is an override and the 
name can't be changed. The way to fix the problem in compiling for 
swf9 is to specify a default value for the second argument. I also 
changed it in baseradio.  baseedittext has a similar issue but 
setValue() has 3 arguments. The change appears to be safe (because 
the old override of setValue did not call the base class).

Tests:
The following test works properly in swf8/swf9, dhtml.

<canvas>
<include href="incubator/lzradio_resources.lzx" />
<include href="incubator/lzradio.lzx" />

<include href="incubator/newcheckbox.lzx" />

<simplelayout spacing="20"/>

<baseradiogroup layout="class:simplelayout" bgcolor="%cccccc">
   <lzradiobutton value="1">Button 1</lzradiobutton>
   <lzradiobutton value="2">Button 2</lzradiobutton>
   <lzradiobutton value="3">Button 3</lzradiobutton>
</baseradiogroup>

<newcheckbox bgcolor="%cccccc">Checkbox 1</newcheckbox>

</canvas>


Files:
M      lps/components/incubator/basecheckbox.lzx
M      lps/components/incubator/baseradio.lzx


http://svn.openlaszlo.org/openlaszlo/patches/20090201-Philip-0.tar