[Laszlo-dev] For Review: Change 20090428-maxcarlson-v Summary: Back out string coercion for lz.DataElement attribute values

André Bargull andre.bargull at udo.edu
Tue Apr 28 14:04:07 PDT 2009


I think the arguments for Debug.info() are in the wrong order, it should 
be Debug.info("...", val, k) instead of Debug.info("...", k, val).
Otherwise approved.

On 4/28/2009 10:49 PM, Max Carlson wrote:
> Change 20090428-maxcarlson-v by maxcarlson at Bank on 2009-04-28 13:40:00 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Back out string coercion for lz.DataElement attribute values
> 
> Bugs Fixed: LPP-8083 - LPP-8083 - 
> LzDataElement.setAttribute('attributes', {...}) forces attribute values 
> to strings
> 
> Technical Reviewer: andre.bargull at udo.edu
> QA Reviewer: ptw at laszlosystems.com
> 
> Release Notes: The upcoming release should note that lz.LzDataElement 
> attribute values will be coerced to Strings in the future to be 
> compliant with the DOM spec - see 
> http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/core.html#ID-F68F082. 
> 
> 
> Details: Fix nits from reviewer - add * type for val, imrpove error 
> message, change to a Debug.info() to be easily filtered, and back out 
> String coercion for now.
> 
> Tests: See LPP-8083 - you should get a message in the debugger, but the 
> value should remain as-is.
> 
> Files:
> M      WEB-INF/lps/lfc/data/LzDataElement.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090428-maxcarlson-v.tar
> 


More information about the Laszlo-dev mailing list