[Laszlo-dev] For Review: Change 20090423-maxcarlson-5 Summary: Add warnings for non-string LzDataElement attributes

André Bargull andre.bargull at udo.edu
Sat Apr 25 09:37:34 PDT 2009


Two nits:
- please add `*`-type to the "val"-variable
- maybe it should say "lz.DataElement" instead of "LzDataElement"

Otherwise approved.


On 4/24/2009 12:50 AM, Max Carlson wrote:
> Change 20090423-maxcarlson-5 by maxcarlson at Bank.local on 2009-04-23 
> 15:45:43 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Add warnings for non-string LzDataElement attributes
> 
> Bugs Fixed: LPP-8083 - LzDataElement.setAttribute('attributes', {...}) 
> forces attribute values to strings
> 
> Technical Reviewer: andre.bargull at udo.edu
> QA Reviewer: ptw at laszlosystems.com
> 
> Details: Add warnings when an attribute is assigned a non-string value.
> 
> Tests: See LPP-8083
> 
> Files:
> M      WEB-INF/lps/lfc/data/LzDataElement.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090423-maxcarlson-5.tar
> 


More information about the Laszlo-dev mailing list