[Laszlo-dev] For Review: Change 20090415-bargull-K1E Summary: more lfc-data updates

[Henry Minsky]

approved!

On Wed, Apr 15, 2009 at 12:51 PM, André Bargull <andre.bargull at udo.edu>wrote:

> Change 20090415-bargull-K1E by bargull at dell--p4--2-53 on 2009-04-15
> 15:31:31
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: more lfc-data updates
>
> New Features:
>
> Bugs Fixed: LPP-8057 (still some minor update for lfc-data possible)
>
> Technical Reviewer: hminsky
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> LzDataNode:
> - added typing to dependencies methods (getPreviousSibling, getNextSibling)
> - removed optional parameter from serialize() (not an official and approved
> public API change, added in r8736 only to avoid swf9-runtime error; and not
> properly implemented see e.g. LzDataText)
> - use identity comparison in childOfNode()
>
> LzDataElement:
> - added more missing typing (LPP-7637 can be ignored in this case, unlikely
> anyone will subclass from LzDataElement)
> - childNodes is never `null` therefore the null-check in appendChild() can
> be removed
> - enforce string-coercion in "attributes"-setter for consistency with
> setAttr()
> - remove null-check for ownerDocument in "attributes"-setter, it should
> never be null
> - general: use local variable for array-length when iterating over arrays
> - copy "attributes"-object (by calling setter) in LzDataElement constructor
> to avoid possible data inconsistency when users change manually object after
> creating LzDataElement instance
> - require that both childNodes and attributes are non-null in constructor
>
> LzDataText:
> - remove unused, poorly documented "length" property
>
> LzDataset:
> - replace calls to Function#apply(), see LPP-8016
> - require that both childNodes and attributes are non-null in construct()
>
>
> Tests:
> (smokecheck, alldata) x (swf8, swf9, dhtml)
>
> Files:
> M WEB-INF/lps/lfc/data/LzDataText.lzs
> M WEB-INF/lps/lfc/data/LzDataNode.lzs
> M WEB-INF/lps/lfc/data/LzDataElement.lzs
> M WEB-INF/lps/lfc/data/LzDataset.lzs
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20090415-bargull-K1E.tar
>
>


-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20090415/5c3f626e/attachment.html