[Laszlo-dev] For Review: Change 20090408-ptw-e Summary: Reduce calls to LzTextSprite/getTextDimension

[André Bargull]

Two issues:
- one missing var declaration for "lineheight" in 
"LzTextSprite.prototype.getLineHeight()"
- "LzTextSprite.prototype.getTextDimension()": the quick check for 
'lineheight' should neither test for _cacheTextKey nor update 
_cacheTextKey (just as in "LzTextSprite.prototype.getLineHeight()"), or 
a call to getTextDimension('lineheight') invalidates the quick cache for 
'width' and 'height'

We should test the cache hit rate of LzTextSprite.prototype._sizecache 
and the influence of the quick cache.

>
> On Wed, Apr 8, 2009 at 3:17 PM, P T Withington <ptw at pobox.com 
> <mailto:ptw at pobox.com>> wrote:
>
>     Change 20090408-ptw-e by ptw at dueling-banjos.home on 2009-04-08
>     14:03:38 EDT
>        in /Users/ptw/OpenLaszlo/trunk-3
>        for http://svn.openlaszlo.org/openlaszlo/trunk
>
>     Summary: Reduce calls to LzTextSprite/getTextDimension
>
>     Bugs Fixed: LPP-8016 Performance differences between OL 4.0.x and
>     4.3.x
>
>     Technical Reviewer: a.bargull at intensis.de
>     <mailto:a.bargull at intensis.de> (pending)
>     QA Reviewer: mkolenda (pending)
>
>     Details:
>        Moved the quick cache check into the callers of getTextDimension,
>        avoiding the call if the cached value is still valid.
>
>     Tests:
>        smokecheck
>        test/lztest/lztest-textheight.lzx?debug=true&lzr=dhtml&lzt=testboth
>
>     Files:
>     M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
>
>     Changeset:
>     http://svn.openlaszlo.org/openlaszlo/patches/20090408-ptw-e.tar
>
>