[Laszlo-dev] [Fwd: For Review: Change 20090405-maxcarlson-q Summary: Add support for resource tiling to swf and dhtml runtimes]

[André Bargull]

SWF:
- When I opened and then closed the Firebug console, the bitmap wasn't 
redrawn completely, instead a part was left blank (see attachment).
- Q: Can't you reuse the identity matrices instead of creating a new one 
for every a call?
- Q: Isn't it necessary to call dispose() on the BitmapData-object to 
reclaim memory? I'm just curious because there is a special method on 
BitmapData for this purpose.

DHTML:
- In setTiling(), you need to call setSource() with the usecache 
parameter set to true, otherwise skiponload will be ignored.
- The "this.tiling"-checks in __updateTiling() aren't necessary, because 
the function is only called when tiling==true.
- Tiling doesn't work when it's first set to false and you later enable 
tiling, e.g. onclick. So basically in setTiling(), style.backgroundImage 
needs to be set if an image is already attached.
- There is currently no support for reporting image loading failures. In 
fact there is even an 'onload' event although the image-url was invalid.

- another bug (was already present earlier): the frames-array isn't 
cleared when a resource-image is removed or replaced with a http-image, 
this may lead to a couple of bugs, cf. play(), stop(), etc.


General Question: Don't we also want to support repeat/tiling on a 
specific axis instead of just repeat-both?



On 4/6/2009 12:55 AM, Max Carlson wrote:
> 
> 
> Change 20090405-maxcarlson-q by maxcarlson at Bank on 2009-04-05 15:31:54 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Add support for resource tiling to swf and dhtml runtimes
> 
> New Features: Views now support a 'tiling' attribute.  Tiling and 
> stretches can't be set at the same time.
> 
> Bugs Fixed: LPP-7714 - Components: DHTML implementation for tiling, 
> LPP-7715 - Components: Tiling - bitmap fill support (partial)
> 
> Technical Reviewer: abargull
> QA Reviewer: hminsky
> 
> 
> Details: swf/LzSprite.as - Add tiling capability, set to true.  If 
> tiling, update on setWidth(), setHeight() and stop().  Add 
> implementation of setTiling() to be called by view.
> 
> dhtml/LzSprite.js - Add tiling capability, set to true.  Refactor img 
> tag creating logic to shared method.  Add tiling setup to setSource().  
> If tiling, update on setWidth(), setHeight() and frame updates.  Add 
> implementation of setTiling() to be called by view.
> 
> swf9/LzSprite.as -  Add tiling capability, set to false.
> 
> LaszloView.lzs - Call tiling setter from init method to guarantee it 
> runs before resources are set.  Add warning to stretches setter and turn 
> off tiling if tiling is on.  Add tiling property, setter which calls 
> sprites - warn if stretches is on, and turn off when setting tiling == 
> true.
> 
> Tests: See LPP-7714 for a testcase which should work in DHTML and swf.
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
> M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090405-maxcarlson-q.tar
-------------- next part --------------
A non-text attachment was scrubbed...
Name: swf_firebug.png
Type: image/png
Size: 46987 bytes
Desc: not available
Url : http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20090406/2239c1a3/swf_firebug-0001.png