[Laszlo-dev] For Review: Change 20090401-hqm-L Summary: fix swf9 embedded font declarations

P T Withington ptw at laszlosystems.com
Wed Apr 1 19:20:37 PDT 2009


Looks good.  Thanks for integrating!

I wonder if saying `LzFont?` would have been more accurate?  Is it  
just because it may be null?

On 2009-04-01, at 21:30EDT, Henry Minsky wrote:

> I integrated it to 4.3 already,  I updated the bug report with the svn
> info.
>
> On Wed, Apr 1, 2009 at 9:08 PM, Amy Muntz <amy.muntz at gmail.com> wrote:
>
>> Thanks, Henry.
>> Tucker - please review and integrate so that it gets into the branch.
>>
>> Thanks!
>> --- Amy
>>
>> On Wed, Apr 1, 2009 at 7:02 PM, Henry Minsky <henry.minsky at gmail.com>
>> wrote:
>>> I am going to commit this pre-review, it's low risk, and want to  
>>> get it
>> into
>>> the build
>>>
>>>
>>> Change 20090401-hqm-L by hqm at badtzmaru.home on 2009-04-01 19:01:21  
>>> EDT
>>>   in /Users/hqm/openlaszlo/trunk/WEB-INF/lps/lfc
>>>   for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc
>>>
>>> Summary:  fix swf9 embedded font declarations
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-8011
>>>
>>> Technical Reviewer: ptw
>>> QA Reviewer: (pending)
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details:
>>>
>>> + change type of var in lookup from LzFont to Object
>>>
>>>
>>> Tests:
>>>
>>> embedded font example runs without error
>>>
>>> <canvas>
>>> <font src="uni-5-plain-expanded-s.ttf" name="myfont"/>
>>> <text font="myfont">myfont is oh-so good!</text>
>>> </canvas>
>>>
>>>
>>> Files:
>>> M      kernel/swf9/LzFontManager.as
>>>
>>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20090401-hqm-L.tar
>>>
>>
>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com



More information about the Laszlo-dev mailing list