[Laszlo-dev] For Review: Change 20090401-hqm-x Summary: fix for clickable text DHTML bug

P T Withington ptw at laszlosystems.com
Wed Apr 1 12:49:48 PDT 2009


Approved.  This seems like the lowest-risk change to fix this bug.

Unless there are any objections, I will integrate this to 4.3.

Let's open a new bug for 4.4 to look into the Question.  We should  
definitely also evaluate _keeping_ the `overflow: hidden` style and  
dropping the clip rectangle.  It seems likely to me that the former  
would be more efficient to render in most browsers.

On 2009-04-01, at 15:20EDT, Henry Minsky wrote:

> Change 20090401-hqm-x by hqm at badtzmaru.home on 2009-04-01 15:16:59 EDT
>    in /Users/hqm/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary:  fix for clickable text DHTML bug
>
> New Features:
>
> Bugs Fixed: LPP-8007
>
> Technical Reviewer: ptw
> QA Reviewer: a.bargull
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> + use a CSS style for the text click div classes which does not have  
> "overflow=hidden" set.
>
> + created a parallel set of CSS classes, named  
> "lz*textcontainer_click", to be used in the
> click div hierarchy
>
> Question: do we really need the overflow=hidden in the lztext CSS  
> classes? It seemed to risky
> to remove them right before a release.
>
> Tests:
>
> + test case from bug
> + calendar DHTML
> + amazon DHTML
>
> Files:
> M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090401-hqm-x.tar



More information about the Laszlo-dev mailing list