[Laszlo-dev] Proposal to merge to 4.3: [Laszlo-checkins] r13566 - in openlaszlo/trunk: lps/components/av lps/components/extensions/av test/video
P T Withington
ptw at pobox.com
Wed Apr 1 01:49:38 PDT 2009
Done.
On 2009-03-31, at 19:24EDT, Amy Muntz wrote:
>
> I'm fine with checking this in and merging to 4.3. Tucker - can you
> do the merge?
> Then, it should be in tonight's final build.
> Thanks!
> Amy
>
> On Tue, Mar 31, 2009 at 7:09 PM , Max Carlson wrote:
>
> This is an extremely low-risk change - all that happened is an
> attribute name changed to be something that more accurately
> describes what it does - videoView.showFrame -> startTime. I think
> this should go into 4.3 because this is a new attribute/feature and
> it's important to get the naming correct the first time - otherwise
> it becomes much more difficult to change.
>
> --
> Regards,
> Max Carlson
> OpenLaszlo.org
>
> ------------------------------
>
> From: sallen at openlaszlo.org
> To: laszlo-checkins at openlaszlo.org
> Date: Tue Mar 31 15:58:51 PDT 2009
> Subject: [Laszlo-checkins] r13566 - in openlaszlo/trunk: lps/
> components/av lps/components/extensions/av test/video
>
> Author: sallen
> Date: 2009-03-31 15:58:50 -0700 (Tue, 31 Mar 2009)
> New Revision: 13566
>
> Modified:
> openlaszlo/trunk/lps/components/av/videoplayer.lzx
> openlaszlo/trunk/lps/components/av/videoscreen.lzx
> openlaszlo/trunk/lps/components/extensions/av/videoview.lzx
> openlaszlo/trunk/test/video/test-stream-video.lzx
> openlaszlo/trunk/test/video/test-videoplayer-http.lzx
> Log:
> Change 20090331-sallen-a by sallen at sallen-mac.local <mailto:sallen at sallen-mac.local
> > <mailto:sallen at sallen-mac.local> on 2009-03-31 15:28:54 PDT
> in /Users/sarah/src/svn/openlaszlo/trunk-review/test/video
> for http://svn.openlaszlo.org/openlaszlo/trunk/test/video <http://svn.openlaszlo.org/openlaszlo/trunk/test/video
> > <http://svn.openlaszlo.org/openlaszlo/trunk/test/video>
>
> Summary: videoView.showFrame -> startTime
>
> New Features:
>
> Bugs Fixed: LPP-799 videoView.showFrame -> startTime
>
> Technical Reviewer: max
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
> doc'd in reference
>
> Release Notes:
>
> Details:
>
>
> Tests:
>
>
> Modified: openlaszlo/trunk/lps/components/av/videoplayer.lzx
> ===================================================================
> --- openlaszlo/trunk/lps/components/av/videoplayer.lzx 2009-03-31
> 22:30:35 UTC (rev 13565)
> +++ openlaszlo/trunk/lps/components/av/videoplayer.lzx 2009-03-31
> 22:58:50 UTC (rev 13566)
> @@ -28,15 +28,17 @@
> see mediastream for details -->
> <attribute name="url" type="string" value=""/>
>
> - <!--- Show this frame when the url is set.
> - Use -1 to show no frame.
> - Default: 0 -->
> - <attribute name="showframe" type="number" value="0"/>
>
> <!--- when true, playback will start automatically
> without user action -->
> <attribute name="autoplay" value="false"/>
>
> + <!--- Show the frame from this time (in seconds) whenever
> the url
> + is set for video playback.
> + Use -1 to show no frame (which will leave the image as it
> + was when switching videos) -->
> + <attribute name="starttime" value="0" type="number"/>
> +
> <!--- why would you want this? no test case, marking private
> @access private -->
> <attribute name="showscreen" value="true"/>
> @@ -122,7 +124,7 @@
> autoplay="${classroot.autoplay}"
> url="${classroot.url}"
> volume="${parent.vslider.volume}"
> - showframe="${parent.showframe}"
> + starttime="${parent.starttime}"
> borderTop="${parent.borderTop}"
> borderLeft="${parent.borderLeft}"
> borderBottom="${parent.borderBottom}"
>
> Modified: openlaszlo/trunk/lps/components/av/videoscreen.lzx
> ===================================================================
> --- openlaszlo/trunk/lps/components/av/videoscreen.lzx 2009-03-31
> 22:30:35 UTC (rev 13565)
> +++ openlaszlo/trunk/lps/components/av/videoscreen.lzx 2009-03-31
> 22:58:50 UTC (rev 13566)
> @@ -16,7 +16,7 @@
>
> <!--- true for verbose debug logging -->
> <attribute name="debug" value="false"/>
> - <attribute name="showframe" value="0"/>
> + <attribute name="starttime" value="0" type="number"/>
> <attribute name="type" type="string" value="http"/>
>
> <attribute name="url" type="string" value=""/>
> @@ -75,6 +75,7 @@
> stream="$once{classroot.ms}"
> visible="${parent.visible && (this.width >
> 1) && (this.height > 1)}"
> playvolume="${classroot.volume}"
> + starttime="${classroot.starttime}"
> debug="${parent.debug}"
> >
>
>
> Modified: openlaszlo/trunk/lps/components/extensions/av/videoview.lzx
> ===================================================================
> --- openlaszlo/trunk/lps/components/extensions/av/videoview.lzx
> 2009-03-31 22:30:35 UTC (rev 13565)
> +++ openlaszlo/trunk/lps/components/extensions/av/videoview.lzx
> 2009-03-31 22:58:50 UTC (rev 13566)
> @@ -54,9 +54,11 @@
> Default: false. -->
> <attribute name="autoplay" value="false"/>
>
> - <!--- Show this frame when the url is set for recorded video.
> - Use -1 to show no frame-->
> - <attribute name="showframe" value="0"/>
> + <!--- Show the frame from this time (in seconds) whenever the url
> + is set for video playback.
> + Use -1 to show no frame (which will leave the image as it
> + was when switching videos) -->
> + <attribute name="starttime" value="0" type="number"/>
>
> <!--- If true, Debug.write extra stuff (this may go away). -->
> <attribute name="debug" value="false"/>
> @@ -164,8 +166,8 @@
> this.stream, "onplaying")
> if (this.stream.playing || this.stream.type == 'http') {
> // show poster frame now for http streams
> - if (!this.stream.playing && this.showframe != -1) {
> - this.stream.seek(this.showframe);
> + if (!this.stream.playing && this.starttime != -1) {
> + this.stream.seek(this.starttime);
> }
> this._setPlayStream();
> }
> @@ -286,7 +288,7 @@
>
> <method name="_updateStreamUrl"> <![CDATA[
> //Debug.write("%w _updateStreamUrl %w %w",
> - // this, this.url, this.showframe);
> + // this, this.url, this.starttime);
> this.stream.setAttribute("url", this.url);
>
> ]]>
>
> Modified: openlaszlo/trunk/test/video/test-stream-video.lzx
> ===================================================================
> --- openlaszlo/trunk/test/video/test-stream-video.lzx 2009-03-31
> 22:30:35 UTC (rev 13565)
> +++ openlaszlo/trunk/test/video/test-stream-video.lzx 2009-03-31
> 22:58:50 UTC (rev 13566)
> @@ -22,7 +22,7 @@
> <simplelayout axis="y" inset="10" spacing="5"/>
> <constantlayout axis="x" value="10"/>
> <text>v2: don't show first frame initially</text>
> - <videoview id="v2" showframe="-1">
> + <videoview id="v2" starttime="-1">
> <mediastream id="s2"
> url="http:videos/good-dog.flv"/>
> </videoview>
>
> Modified: openlaszlo/trunk/test/video/test-videoplayer-http.lzx
> ===================================================================
> --- openlaszlo/trunk/test/video/test-videoplayer-http.lzx 2009-03-31
> 22:30:35 UTC (rev 13565)
> +++ openlaszlo/trunk/test/video/test-videoplayer-http.lzx 2009-03-31
> 22:58:50 UTC (rev 13566)
> @@ -8,11 +8,11 @@
> <simplelayout axis="x" spacing="10"/>
> <view layout="axis:y">
> <text multiline="true">
> - v1: showframe="1"<br/>
> + v1: starttime="1"<br/>
> showTimeDisplay="false" showVolumeControl="false"<br/>
> progressColor="0x0000cc" border="1" sliderGap="0"
> </text>
> - <videoplayer id="v1" showframe="1"
> + <videoplayer id="v1" starttime="1"
> showTimeDisplay="false" showVolumeControl="false"
> progressColor="0x0000cc"
> border="1" sliderGap="0"
>
> _______________________________________________
> Laszlo-checkins mailing list
> Laszlo-checkins at openlaszlo.org <mailto:Laszlo-
> checkins at openlaszlo.org> <mailto:Laszlo-checkins at openlaszlo.org>
> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins <http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
> > <http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins>
More information about the Laszlo-dev
mailing list