[Laszlo-dev] For Review: 20080930-laszlo-6 Summary: SWF8/9 and DHTML: Selecting a tag does not change the picture search

[Philip Romanik]

Approved!

The convert_setters.pl script must have been run before I fixed this 
issue. The current version of convert_setters will warn the user that 
there is an existing setText() method and not update the calls in 
search.lzx. The script will update the other 2 files but the warning 
message tells the user to do a manual check of the changes.




>Change 20080930-laszlo-6 by laszlo at T43-L3XEXMW on 2008-09-30 03:48:32 EDT
>     in /home/laszlo/src/svn/openlaszlo/trunk-bigboss
>     for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: SWF8/9 and DHTML: Selecting a tag does not change the picture search
>
>New Features:
>
>Bugs Fixed: LPP-7085 - SWF8/9 and DHTML: Selecting a tag does not 
>change the picture search
>
>Technical Reviewer: promanik
>QA Reviewer: max
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: There was a method called "setText" on class
>     search that wasn't our usual setText method, and
>     when it was changed to setAttribute('text', foo)
>     it broke tag searching.  I renamed this method
>     "setTxt", since it's setting a text object named
>     "txt" that's further within the class "search",
>     and changed any improperly-corrected instances of
>     setAttribute().  This should avoid confusion, and
>     keep it from getting changed again at any point in
>     the future.
>
>Tests: Run LzPix in any of the runtimes.  Click the flower.
>     Click one of the images that appears.  Click a tag,
>     preferably one that would result in a set of images with
>     an easily identifiable theme.  (Say, cat.)  The resulting
>     images from the search should all be what you'd expect from
>     clicking on the tag.
>
>Files:
>M      demos/lzpix/classes/search.lzx
>M      demos/lzpix/classes/favorites.lzx
>M      demos/lzpix/views/details.lzx
>
>Changeset:
><http://svn.openlaszlo.org/openlaszlo/patches/20080930-laszlo-6.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080930-laszlo-6.tar
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080930/ecfb7fff/attachment.html