[Laszlo-dev] For Review: 20080930-laszlo-6 Summary: SWF8/9 and DHTML: Selecting a tag does not change the picture search

[P T Withington]

Another way to handle this, which I think would be more in the modern  
spirit, would be to rewrite the setText method you found as a setter.   
I'm guessing this method is trying to make a class that behaves as if  
it has a text attribute, but is storing the text in some child text  
object, so you would do something like:

<setter name="text" args="newValue">
   some.inner.child.setAttribute('text', newValue);
</setter>

BTW, I think our style guide frowns on using 'C' names for variables,  
like 'txt'. :)

On 2008-09-30, at 06:09EDT, J Crowley wrote:

> Change 20080930-laszlo-6 by laszlo at T43-L3XEXMW on 2008-09-30  
> 03:48:32 EDT
>   in /home/laszlo/src/svn/openlaszlo/trunk-bigboss
>   for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: SWF8/9 and DHTML: Selecting a tag does not change the  
> picture search
>
> New Features:
>
> Bugs Fixed: LPP-7085 - SWF8/9 and DHTML: Selecting a tag does not  
> change the picture search
>
> Technical Reviewer: promanik
> QA Reviewer: max
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: There was a method called "setText" on class
>   search that wasn't our usual setText method, and
>   when it was changed to setAttribute('text', foo)
>   it broke tag searching.  I renamed this method
>   "setTxt", since it's setting a text object named
>   "txt" that's further within the class "search",
>   and changed any improperly-corrected instances of
>   setAttribute().  This should avoid confusion, and
>   keep it from getting changed again at any point in
>   the future.
>
> Tests: Run LzPix in any of the runtimes.  Click the flower.
>   Click one of the images that appears.  Click a tag,
>   preferably one that would result in a set of images with
>   an easily identifiable theme.  (Say, cat.)  The resulting
>   images from the search should all be what you'd expect from
>   clicking on the tag.
>
> Files:
> M      demos/lzpix/classes/search.lzx
> M      demos/lzpix/classes/favorites.lzx
> M      demos/lzpix/views/details.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080930-laszlo-6.tar
>
>