[Laszlo-dev] For Review: Change 20080922-ptw-V Summary: Fix LzEvent printing in debugger, address Andre's comments

[André Bargull]

Approved, if you amend "isArrayLike" to test for object existence (to 
avoid an "undefined property error" in swf8):
---
public function isArrayLike (obj:*)/* :Boolean */ {
    if (*obj && *((obj is Array) || (obj['length'] != (void 0)))) {
---
+ similar change in the swf9 version


On 9/23/2008 12:51 AM, P T Withington wrote:
> [I'll check this in because I think it improves the swf9 debugging 
> experience...]
>
> Change 20080922-ptw-V by ptw at dueling-banjos.local on 2008-09-22 
> 12:22:20 EDT
>     in /Users/ptw/OpenLaszlo/honey-dew-3
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix LzEvent printing in debugger, address Andre's comments
>
> Bugs Fixed:
> LPP-6880 tagnames of anonymous classes
>
>
> Technical Reviewer: hminsky, a.bargull at intensis.de (pending)
>
> Details:
>     LzMessage*, LzMemory : make length property public
>
>     LzDebug: Restore printLength on error; use isObjectLike for
>     uniqify test, not `typeof == 'object'` which is tripped up by
>     null; answer your own questions in inspectInternal; make sure
>     errors from inspectInternal are inspectable; share isArrayLike
>     test with objectOwnProperties; use care poking at object
>     prototypes.
>
>     LzDebug.js, swf/LzDebug.as: Improvements from Andre
>
>     swf9/LzDebug.as: Use describeType to avoid errors looking for
>     'length' on sealed types in isArrayLike.
>
>     LaszloEvents: Improve debug printer
>
>     LzFormatter: Add alternate (#) for %s formatting to indicate
>     truncation by ...
>
>     Class: Put _dbg_name back on Traits
>
> Tests:
>     No longer get an error printing or inspecting an LzEvent object
>
> Files:
> M      WEB-INF/lps/lfc/debugger/LzMessage.lzs
> M      WEB-INF/lps/lfc/debugger/LzDebug.lzs
> M      WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
> M      WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
> M      WEB-INF/lps/lfc/debugger/LzMemory.lzs
> M      WEB-INF/lps/lfc/events/LaszloEvents.lzs
> M      WEB-INF/lps/lfc/compiler/LzFormatter.lzs
> M      WEB-INF/lps/lfc/compiler/LzMessage.lzs
> M      WEB-INF/lps/lfc/compiler/Class.lzs
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080922-ptw-V.tar
>