[Laszlo-dev] For Review: Change 20080922-dda-G Summary: SWF9: Identify and report Java heap space errors that happen during compilation correctly.

[Donald Anderson]

Change 20080922-dda-G by dda at lester.local on 2008-09-22 17:09:40 EDT
     in /Users/dda/laszlo/src/svn/openlaszlo/trunk-c
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: SWF9: Identify and report Java heap space errors that happen  
during compilation correctly.

New Features:

Bugs Fixed:

Technical Reviewer: hminsky (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
     If 'stray errors' (not attached to a line number) occur, they may  
not be put
     into the exception string and so may never be seen by an end  
user.  Instead,
     a cryptic message like 'Errors from compiler, output file not  
created',
     or 'FAIL: compiler returned [Ljava.lang.Integer;@df3dee' might  
result.

     This change specifically looks for the kinds of messages that  
result
     from java heap space errors and collects them into a list of  
severe errors.
     We'll be able to add other kinds of errors when we can identify  
them.

     Severe errors are always reported first -- and are always  
reported, unlike
     the current situation.

     Fixed the [Ljava.lang.... issue also, a botched println.

Tests:
     Ran lots of programs until I saw this error compiling SWF9  
debug.  I now see
     (in the browser):

         Compilation Errors

         org.openlaszlo.sc.CompilerError: SEVERE ERROR: Error: Java  
heap space
         SEVERE ERROR: java.lang.OutOfMemoryError: Java heap space

     There is an equivalent error in the catalina.log for tomcat.

     It's true that the nature of the error string may be system  
dependent (though Sun JVM's
     are likely to be the same).

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080922-dda-G.tar



--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080922/d797877b/attachment.html