[Laszlo-dev] For Review: Change 20080919-ptw-i Summary: Arr. Some tasty bits for the debugger

[André Bargull]

"prototype"-objects and mixins don't work properly:

Debug.__typeof(lz.canvas.prototype) prints:
> '<view>'
´lz.canvas.prototype´ prints:
> «<view>#0| <canvas>.prototype» 

> + // _dbg_name not needed because functionName computes class
> + // names now
But not for mixins: Debug.functionName(LzFormatter) == null
Also type into the debugger ´LzFormatter´:
> «Trait#8| {…, classname: LzFormatter, _dbg_typename: Trait, prototype: 
> [object Object], instanceProperties: formatToString,[type 
> Function],pad,[type Function], implementations: [object Object]}»

Some other changes (update for __StringDescription(), fix for 
IE-debugger, boolean coercion in isObjectLike() and some more tiny 
things) are here:
"http://svn.openlaszlo.org/openlaszlo/patches/20080920-bargull-sLz.tar".


BTW, why do the CSS-classes "span.DEBUG, span.INFO, span.WARNING, 
span.ERROR, span.TRACE, span.MONITOR span.INSPECT" have got "cursor: 
pointer"?
1) a comma is missing in front of "span.INSPECT", that'll break a lot of 
things..
2) only "span.INSPECT" should be inspectable, shouldn't it?


On 9/20/2008 4:45 AM, P T Withington wrote:
> [Addressing André's review comments. Checking in because this improves 
> the debugger in all platforms...]
>
> Change 20080919-ptw-i by ptw at dueling-banjos.local on 2008-09-19 
> 08:19:53 EDT
> in /Users/ptw/OpenLaszlo/honey-dew-3
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Arr. Some tasty bits for the debugger
>
> Bugs Fixed:
> LPP-6880 tagnames of anonymous classes (review comments)
>
> Technical Reviewer: a.bargull at intensis.de (pending)
> QA Reviewer: hminsky (pending)
>
> Details:
> lzunit-test: type-oh discovered by the flex compiler
>
> LzInit, LzDebug.js: Remove old naming of singletons code, now that
> the debugger handles them better.
>
> LzDebug*: trust functionName for names of classes, make
> functionName more accurate for class names for each platform by
> refactoring.
>
> swf9/LzDebug: refine isObjectLike to not confuse auto-wrapped
> primitives with Object.
>
> Class: Remove custom _dbg_name now that debugger handles Class
> more uniformly, add _dbg_prototype_for so the debugger can decode
> prototypes appropriately.
>
> lzunit: Instead of inheriting from text, delegate formatting to a
> text node -- because you don't actually contain any text.
>
> Tests:
> Poked at various things in the debugger in swf8/9 and dhtml, and
> they look reasonable
>
> Files:
> M test/smoke/lzunit-test.lzl
> M WEB-INF/lps/lfc/debugger/LzInit.lzs
> M WEB-INF/lps/lfc/debugger/LzDebug.lzs
> M WEB-INF/lps/lfc/debugger/platform/swf/LzDebug.as
> M WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
> M WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
> M WEB-INF/lps/lfc/compiler/Class.lzs
> M lps/components/lzunit/lzunit.lzx
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080919-ptw-i.tar