[Laszlo-dev] For Review: Change 20080918-maxcarlson-H Summary: Turn off history by default.

[André Bargull]

- LzTextSprite/LzInputTextSprite (swf) requires the 'args'-parameter
- remove lz.History.__start() from LzSprite (dhtml)
- typo in LzCanvas#construct()? "if (args.accessibility)" -> if 
"(args.accessible)"
- Also LzCanvas#construct(): 'lzproxied' -> 'history'?
> var historyarg = lz.Browser.getInitArg('lzproxied');



On 9/18/2008 9:13 PM, Max Carlson wrote:
> Change 20080918-maxcarlson-H by maxcarlson at Bank on 2008-09-18 11:47:34 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Turn off history by default.
> 
> Bugs Fixed: LPP-6708 - history mechanism goes wild
> 
> Technical Reviewer: ptw
> QA Reviewer: andre.bargull at udo.edu
> 
> Details: lfc.lzx - Add history attribute to canvas.
> 
> */LzBrowserKernel.lzs - Add getAppID() to return the id the app was 
> started with.
> 
> swf8/LzSprite.as - Update LzSprite constructor signature to not expect 
> args.  Add history capability, set to true.  Move history startup to the 
> canvas.
> 
> dhtml/LzSprite.js - Add history capability, set to true.
> 
> swf9/LzSprite.as - Update LzSprite constructor signature to not expect 
> args.    Add history capability, set to false.
> 
> LzBrowser.lzs - Add getAppID() to return the id the app was started with.
> 
> LzUtils.lzs - Update lastscope correctly, use when unpacking the args to 
> get the proper scope for attribute names.
> 
> LzHistory.lzs - Add capabilities property for setPersist().  __start() 
> now expects an app id so it can tell the history system it wants to 
> listen for events.
> 
> LzDefs.lzs - Add reference for lz in the 'global' object.
> 
> LaszloView.lzs - Clean out cruft, don't pass args to __makeSprite().  
> __makeSprite() uses the new LzSprite constructor signature (no args).
> 
> LaszloCanvas.lzs - Document new canvas.history attribute.  Don't pass 
> args to __makeSprite().  Process history and accessible canvas args, 
> warning if the capability is not available.  Set canvas.id using 
> lz.Browser.getAppID() so it works across all runtimes.  __makeSprite() 
> uses the new LzSprite constructor signature (no args).  Move sprite 
> init() and history startup code to canvas.init().
> 
> CanvasCompiler.java - Set history to true if the canvas.history 
> attribute == 'true'.
> 
> NodeModel.java - id binders add a reference to the 'global' global object.
> 
> Canvas.java - Add getters and setters for the history attribute.  Pass 
> value through to XML model.
> 
> embednew.js - Rely on LFC canvas init to register for history, but allow 
> history: false to deactivate history entirely.  Change accessible arg to 
> expect a boolean value.
> 
> lzhistory.js - Add intervaltime to allow update interval to be set.  New 
> default is 200ms, double what it was.  Separate app registration to 
> listen() method called by the app when it wants to receive history 
> events.  Fix braino in dhtml history method lookup.  Assume the history 
> value was received in Flash, since return values aren't reliable in swf9.
> 
> flash.js - Add (commented out) routines to bypass the dojo call system 
> for testing.
> 
> Tests: 
> http://localhost:8080/trunk-clean/test/lfc/legals/testjscomm/test9.jsp now 
> runs better (the boxes turn green) although it warns about the issue in 
> LPP-7008.  
> http://localhost:8080/trunk-clean/test/lfc/legals/testjscomm/test8.jsp runs 
> as before, but the boxes turn green.  
> http://localhost:8080/trunk-clean/test/history/ runs in swf8 and 
> dhtml(again), and warns that history isn't supported in swf9.
> 
> Files:
> M      WEB-INF/lps/schema/lfc.lzx
> M      WEB-INF/lps/lfc/kernel/swf/LzBrowserKernel.lzs
> M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
> M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzBrowserKernel.lzs
> M      WEB-INF/lps/lfc/kernel/swf9/DojoExternalInterface.as
> M      WEB-INF/lps/lfc/kernel/swf9/LzBrowserKernel.lzs
> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> M      WEB-INF/lps/lfc/services/LzBrowser.lzs
> M      WEB-INF/lps/lfc/services/LzUtils.lzs
> M      WEB-INF/lps/lfc/services/LzHistory.lzs
> M      WEB-INF/lps/lfc/core/LzDefs.lzs
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
> M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Canvas.java
> M      lps/includes/source/embednew.js
> M      lps/includes/source/lzhistory.js
> M      lps/includes/source/flash.js
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080918-maxcarlson-H.tar
>