[Laszlo-dev] For Review: Change 20080918-bargull-ezt Summary: lz.submit compiler error for swf9

[André Bargull]

I'm going to update the following files:
> M      WEB-INF/lps/schema/lfc.lzx
> M      lps/components/base/submit.lzx
> M      lps/components/lz/form.lzx
> M      demos/vacation-survey/vacation-survey.lzx
> M      examples/components/form_example.lzx
> M      laszlo-explorer/basics/form.lzx

But apparently I'm forced to override the pre-commit-check [1] for the 
LaszloExplorer example. How do I do this? Or should send the changeset 
to someone else?


[1] 
http://www.openlaszlo.org/pipermail/laszlo-dev/2008-September/017260.html


On 9/19/2008 10:35 AM, J Crowley wrote:
> Er, could you also include the modified vacation-survey.lzx from my 
> changeset as well (with the modified line 55 to accommodate your 
> change)?  Thanks!
> 
> André Bargull wrote:
>> "obj" should be "this" in the "data" setter in submit.lzx.
>> I've updated the changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20080918-bargull-ezt.tar
>>
>> On 9/18/2008 11:58 PM, J Crowley wrote:
>>> Running vacation-survey.lzx (modified in the change I sent out, 
>>> though with line 55 altered to <submit id="surveysubmit" 
>>> dataset="${surveydataset}" /> per your change) in SWF9 gives the 
>>> following compilation error:
>>>
>>> |org.openlaszlo.sc.CompilerError: base/submit.lzx: 28: Error: Access 
>>> of undefined property obj, in line: 
>>> Debug.info("%w.setAttribute('data') is deprecated. Use 
>>> %w.setAttribute('dataset') instead", obj, obj);
>>> base/submit.lzx: 28: Error: Access of undefined property obj, in 
>>> line: Debug.info("%w.setAttribute('data') is deprecated. Use 
>>> %w.setAttribute('dataset') instead", obj, obj);|
>>>
>>> André Bargull wrote:
>>>> I'd propose to change the "data" property on lz.submit to "dataset" 
>>>> (the setter was already named "setDataset"!), and to include a kind 
>>>> of bwcompat mode, for more infos, see my changeset. Any thoughts on 
>>>> this?
>>>>
>>>>
>>>> Change 20080918-bargull-ezt by bargull at dell--p4--2-53 on 2008-09-18 
>>>> 22:16:37
>>>> in /home/Admin/src/svn/openlaszlo/trunk
>>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>>
>>>> Summary: lz.submit compiler error for swf9
>>>>
>>>> New Features:
>>>>
>>>> Bugs Fixed: LPP-7006
>>>>
>>>> Technical Reviewer: jcrowley
>>>> QA Reviewer: (pending)
>>>> Doc Reviewer: (pending)
>>>>
>>>> Documentation:
>>>>
>>>> Release Notes:
>>>>
>>>> Details:
>>>> adjusted schema, the setter for "data" now lives on LzNode
>>>> changed submit#data to submit#dataset to avoid conflict with 
>>>> LzNode#data
>>>> Still set "data" to maintain bwcomp for the next release, but print 
>>>> a deprecated warning (which is bogus if you want to use LzNode#data...)
>>>> Updated example code in lz.form
>>>>
>>>>
>>>>
>>>>
>>>> Tests:
>>>>
>>>> Files:
>>>> M WEB-INF/lps/schema/lfc.lzx
>>>> M lps/components/base/submit.lzx
>>>> M lps/components/lz/form.lzx
>>>>
>>>> Changeset: 
>>>> http://svn.openlaszlo.org/openlaszlo/patches/20080918-bargull-ezt.tar
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>>
> 
> 
>