[Laszlo-dev] For Review: Change 20080918-ptw-7 Summary: Brain-oh's in r11082

André Bargull andre.bargull at udo.edu
Thu Sep 18 14:32:29 PDT 2008


´lz.canvas._dbg_name´ prints now "LzCanvas" instead of "lz.canvas", 
because the class initializer has been removed from LzNode (needed for 
"_dbg_name"):
> - if ($debug) {
> - // Use the package tag name as the typename
> - this._dbg_name = prototype._dbg_typename = 'lz.' + tagname;
> - }

´lz.text´ prints no longer "«¡¿Class?!(0)#0| lz.text» ", instead it is 
"lz.text" (and not inspectable), but this is also reproducible in rev. 
#11076, so it was broken earlier.

And there is some inconsistency:
Try to inspect ´canvas.subviews´ in the swf8 debugger:
> «Array#null(5)#0| [LzDebugWindow , button, button id=txt, bu…» {
> 0: «$lzc$class_LzDebugWindow»
> 1: button
> 2: #txt
> 3: button
> 4: «$lzc$class_focusoverlay»
> }
Why are "LzDebugWindow" and "focusoverlay" printed with their internal 
classname?
Also reproducible if you create a button through the debugger:
> lzx> new lz.button(canvas)
> «$lzc$class_button#6| button»

testcase:
---
<canvas debug="true">
<button />
<button onclick="Debug.write('test')" id="txt" />
<button x="100" onclick="Debug.write('test')" />
</canvas>
---



On 9/18/2008 10:24 PM, P T Withington wrote:
> [Checking in because my previous change broke things!]
>
> Change 20080918-ptw-7 by ptw at dueling-banjos.local on 2008-09-18 
> 16:20:24 EDT
> in /Users/ptw/OpenLaszlo/honey-dew-3
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Brain-oh's in r11082
>
> Bugs Fixed:
> LPP-6880 tagnames of anonymous classes
>
> Technical Reviewer: a.bargull at intensis.de (pending)
> QA Reviewer: hminsky (pending)
>
> Details:
> Put back swf9 class name heuristic. Remove redundant publishing
> of tag classes (LzNode.initialize).
>
> Tests:
> No more warnings in swf8, class names are back in swf9
>
> Files:
> M WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
> M WEB-INF/lps/lfc/core/LzNode.lzs
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080918-ptw-7.tar
>


More information about the Laszlo-dev mailing list