[Laszlo-dev] For Review: Change 20080917-ptw-z Summary: More swf9 debugger tweaks

André Bargull andre.bargull at udo.edu
Wed Sep 17 10:02:52 PDT 2008


The first "Don't consider strings to be arrays" is not needed, because 
string-like things are handled earlier.

> @@ -798,15 +799,16 @@
>          // Print unidentified objects and arrays as abbreviated list 
> of props
>          else {
>            var names = [];
> -          var indices = this.isArrayLike(thing)?[]:null;
> +          var indices = (this.isArrayLike(thing) && (! 
> this.isStringLike(thing)))?[]:null;

Otherwise approved!

On 9/17/2008 6:39 PM, P T Withington wrote:
> [I am going to check this in because it gets the swf9 debugger working 
> more, but I still can't run smoke/simple.lzx in swf9 any more.  It 
> ends up crashing my browser.  Yesterday I had to reinstall flash and 
> reboot to recover from the crash!]
>
> Change 20080917-ptw-z by ptw at dueling-banjos.local on 2008-09-17 
> 11:49:22 EDT
>     in /Users/ptw/OpenLaszlo/honey-dew-3
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: More swf9 debugger tweaks
>
> Bugs Fixed:
> LPP-6989  Weird issue regarding type coercion with debug=true
>
> Technical Reviewer: a.bargull at intensis.de (pending)
> QA Reviewer: etjabberwock at gmail.com (pending)
>
> Details:
>
>     Move _dbg_name and _dbg_typename to prototypes so we can have a
>     little more flexibility (look for them using `in`, to avoid trying
>     to invoke them on primitive classes, allow them to be strings or
>     functions).
>
>     LzMessage, warnInternal fixes from Andre
>
>     Don't consider strings to be arrays
>
>     Don't look for __proto__ any more, that's obsolete
>
>     Don't complain about _dbg_ annotations when validating class
>     structure.
>
>     Remove obsolete _dbg_ overrides from lzunit
>
> Tests:
>     Test case from bug report no longer errs.  Smokecheck in swf8 and 
> dhtml
>
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs
> M      WEB-INF/lps/lfc/debugger/LzMessage.lzs
> M      WEB-INF/lps/lfc/debugger/LzDebug.lzs
> M      WEB-INF/lps/lfc/core/LzNode.lzs
> M      WEB-INF/lps/lfc/core/LzEventable.lzs
> M      WEB-INF/lps/lfc/views/LzText.lzs
> M      WEB-INF/lps/lfc/views/LzViewLinkage.lzs
> M      WEB-INF/lps/lfc/views/LzViewLinkage.js
> M      WEB-INF/lps/lfc/events/LaszloEvents.lzs
> M      WEB-INF/lps/lfc/data/LzDatapointer.lzs
> M      WEB-INF/lps/lfc/data/LzDataAttrBind.lzs
> M      WEB-INF/lps/lfc/compiler/LzBootstrapDebugService.lzs
> M      WEB-INF/lps/lfc/compiler/Class.lzs
> M      lps/components/lzunit/lzunit.lzx
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080917-ptw-z.tar
>


More information about the Laszlo-dev mailing list