[Laszlo-dev] For Review: Change 20080905-Philip-4. Summary: Modify components to use setAttribute instead of setX

[P T Withington]

Approved pro forma, I'd like to see ant lztest and ant lzunit pass,  
and the nightly megatest.

On 2008-09-05, at 16:51EDT, Philip Romanik wrote:

> Change 20080905-Philip-4 by Philip at Philip-DC on 2008-09-05 16:39:02  
> EDT
>    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Modify components to use setAttribute instead of setX
>
> New Features:
>
> Bugs Fixed: LPP-5644 (partial)
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> I ran a script I wrote (/WEB-INF/lps/server/bin/convert_setters.pl)  
> on the components. This modifies a call like,
>
>  this.setText(t)  ==>   this.setAttribute('text', t);
>
> The tool isn't perfect because some classes define a local methods  
> (ie. setText()) that doesn't derive from a view. However, it is >90%  
> correct.
>
> There are still some setters in other non-view files I need to  
> convert.
>
> I only modified the calendar demo app. I will modify the other apps/ 
> tests as a separate changeset.
>
> I am checking this code in. The most interesting file to look at is  
> convert_setters.pl. It is based upon convert_required.pl.
>
>
>
> Tests:
> component examples work again. recursion errors trying to run  
> calendar are gone. deprecated messages about using setX in the  
> components are gone.
>
>
> Files:
> A      WEB-INF/lps/server/bin/convert_setters.pl
> M      lps/components/queens-charts/shared/piepiece.lzx
> M      lps/components/queens-charts/shared/wholepie.lzx
> M      lps/components/queens-charts/shared/chartzoomer.lzx
> M      lps/components/queens-charts/shared/legend.lzx
> M      lps/components/queens-charts/shared/label.lzx
> M      lps/components/rpc/soap.lzx
> M      lps/components/debugger/debugger.lzx
> M      lps/components/debugger/newcontent.lzx
> M      lps/components/debugger/scrollingtext.lzx
> M      lps/components/charts/columnchart/columnchartplotarea.lzx
> M      lps/components/charts/piechart/piepiece.lzx
> M      lps/components/charts/addon/slider/slider.lzx
> M      lps/components/charts/addon/zoomarea.lzx
> M      lps/components/charts/barchart/barchartplotarea.lzx
> M      lps/components/charts/common/tickmarklabel.lzx
> M      lps/components/charts/common/valuepoints.lzx
> M      lps/components/charts/common/datamarker.lzx
> M      lps/components/charts/common/horizontalaxis.lzx
> M      lps/components/charts/common/label.lzx
> M      lps/components/charts/common/valueregion.lzx
> M      lps/components/charts/common/valueline.lzx
> M      lps/components/charts/common/datatip.lzx
> M      lps/components/charts/common/rectangularchart.lzx
> M      lps/components/charts/common/legend.lzx
> M      lps/components/charts/common/databar.lzx
> M      lps/components/charts/common/verticalaxis.lzx
> M      lps/components/charts/linechart/linechartplotarea.lzx
> M      lps/components/lz/gridcolumn.lzx
> M      lps/components/lz/button.lzx
> M      lps/components/lz/tabelement.lzx
> M      lps/components/lz/listitem.lzx
> M      lps/components/lz/basefloatinglist.lzx
> M      lps/components/lz/hscrollbar.lzx
> M      lps/components/lz/simpletext.lzx
> M      lps/components/lz/floatinglist.lzx
> M      lps/components/lz/menu.lzx
> M      lps/components/lz/alert.lzx
> M      lps/components/lz/combobox.lzx
> M      lps/components/lz/vscrollbar.lzx
> M      lps/components/lz/list.lzx
> M      lps/components/lz/datepicker.lzx
> M      lps/components/lz/slider.lzx
> M      lps/components/lz/scrollbar.lzx
> M      lps/components/lz/windowpanel.lzx
> M      lps/components/lz/edittext.lzx
> M      lps/components/lz/gridtext.lzx
> M      lps/components/lz/datacombobox.lzx
> M      lps/components/incubator/lzcombobox_class.lzx
> M      lps/components/incubator/custombutton.lzx
> M      lps/components/incubator/tooltip/tooltipview.lzx
> M      lps/components/incubator/tooltip/tooltip.lzx
> M      lps/components/incubator/newvscrollbar.lzx
> M      lps/components/incubator/lwzCalendar/lwzEncalendar.lzx
> M      lps/components/incubator/roundrectbutton.lzx
> M      lps/components/incubator/baseslider.lzx
> M      lps/components/incubator/ulink.lzx
> M      lps/components/incubator/baseedittext.lzx
> M      lps/components/incubator/stylishbutton.lzx
> M      lps/components/incubator/validators/basevalidator.lzx
> M      lps/components/incubator/defaultlistitem.lzx
> M      lps/components/incubator/uploader/fileuploadlist.lzx
> M      lps/components/incubator/newhscrollbar.lzx
> M      lps/components/incubator/colorslider.lzx
> M      lps/components/incubator/autocompletecombobox.lzx
> M      lps/components/incubator/test/libflickr-test.lzx
> M      lps/components/incubator/draglib.lzx
> M      lps/components/incubator/opttree/opttree.lzx
> M      lps/components/incubator/vslider.lzx
> M      lps/components/incubator/stepper.lzx
> M      lps/components/incubator/lzeditcombobox.lzx
> M      lps/components/incubator/rich-text/linkdialog.lzx
> M      lps/components/incubator/rich-text/formatfontcolor.lzx
> M      lps/components/incubator/borderinput.lzx
> M      lps/components/extensions/html.lzx
> M      lps/components/extensions/drawview.lzx
> M      lps/components/extensions/av/videoview.lzx
> M      lps/components/extensions/views/richinputtext.lzx
> M      lps/components/utils/performance/library.lzx
> M      lps/components/utils/diagnostic/inittimer.lzx
> M      lps/components/utils/diagnostic/inspector/colormenu.lzx
> M      lps/components/utils/diagnostic/inspector/inspector.lzx
> M      lps/components/utils/diagnostic/frametimer.lzx
> M      lps/components/utils/replicator/replicator.lzx
> M      lps/components/utils/traits/cssable.lzx
> M      lps/components/base/basebutton.lzx
> M      lps/components/base/basegridrow.lzx
> M      lps/components/base/basescrollbar.lzx
> M      lps/components/base/basewindow.lzx
> M      lps/components/base/basecombobox.lzx
> M      lps/components/base/basetabslider.lzx
> M      lps/components/base/basefocusview.lzx
> M      lps/components/base/basedatepicker.lzx
> M      lps/components/base/basetrackgroup.lzx
> M      lps/components/base/baseslider.lzx
> M      lps/components/base/basegrid.lzx
> M      lps/components/base/basedatacombobox.lzx
> M      lps/components/base/basegridcolumn.lzx
> M      lps/components/base/style.lzx
> M      demos/calendar/simpletimelayout.lzx
> M      demos/calendar/cal-button.lzx
> M      demos/calendar/calendar.lzx
> M      demos/calendar/vscrollbar.lzx
> M      demos/calendar/infopanel.lzx
> M      demos/calendar/day.lzx
> M      demos/calendar/event.lzx
> M      demos/calendar/eventselector.lzx
> M      demos/calendar/gridsliderlayout.lzx
> M      demos/calendar/selected-daylook.lzx
> M      demos/calendar/basepanel.lzx
> M      demos/calendar/textbox.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080905-Philip-4.tar
>