[Laszlo-dev] For Review: Change 20080904-hqm-J Summary: call flex compiler classes directly from jar file

[Donald Anderson]

A few items:

1) I'm pretty sure the build.sh/build.bat produced will be broken,
it won't have the pathname of the compile command.  That's a 'nice to  
have'.

2)
+        exitval = flex2.compiler.util.ThreadLocalToolkit.errorCount();
Couldn't find any doc for ThreadLocalToolkit.  Are the errors additive,
or will they be reset to 0 on each call into the compiler?  (i.e. I'm
worried about an error being 'sticky' to the next compile - I guess
it would only result in a stray FAIL println to the error console).

3) If we end up going with this approach then execCompileCommand has
just become dead code.  If we want to keep both approaches around  
(perhaps
extern compile as a backup), then this code should be refactored to get
better sharing.

Otherwise, approved.

On Sep 4, 2008, at 11:50 AM, Henry Minsky wrote:

> I'm going to check this in now, so it gets in the nightly build so  
> that Mamye can test
> it as soon as possible.
>
>
>
> On Thu, Sep 4, 2008 at 11:17 AM, Henry Minsky  
> <henry.minsky at gmail.com> wrote:
> Change 20080904-hqm-J by hqm at badtzmaru.home on 2008-09-04 11:11:21 EDT
>    in /Users/hqm/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary:  call flex compiler classes directly from jar file
>
> New Features:
>
> Bugs Fixed: LPP-6309
>
> Technical Reviewer: dda
> QA Reviewer: mamye
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
>
> Tests:
>
> Mamye, please make sure that when this is built as a nightly, that  
> is installs and runs
> on MacOS and can compiler swf9 properly there, when installed in a  
> path in /Applications
> which has spaces in the pathname.
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080904-hqm-J.tar
>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com
>
>


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080904/181e11e9/attachment.html