[Laszlo-dev] For Review: Change 20080902-maxcarlson-z Summary: Fix dhtml in iPhone
P T Withington
ptw at laszlosystems.com
Wed Sep 3 07:15:56 PDT 2008
The comment here:
+ } else if (this.browser == 'iPhone') {
+ // true if we're on ie and not being spoofed
+ this.isSafari = true;
+ this.isIphone = true;
seems stale. Otherwise, approved. Give me a test case after you
check in and I will verify.
And, I agree that we should not try to do anything fancy with touch/
gesture events just yet. Let's just make it work at all.
On 2008-09-02, at 16:08EDT, Max Carlson wrote:
> Change 20080902-maxcarlson-z by maxcarlson at Bank on 2008-09-02
> 13:03:48 PDT
> in /Users/maxcarlson/openlaszlo/trunk-clean
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix dhtml in iPhone
>
> Bugs Fixed: LPP-6595 - 4.1 DHTML lz.browser.ieIE returns undefined
> instead of false for non-IE browsers, LPP-6564 - OpenLaszlo iphone
> 1.1.3 DHTML: can't type in inputtext
>
> Technical Reviewer: ptw
> QA Reviewer: hminsky
>
> Details: LzSprite.js - Add new listen_for_mouseover_out quirk,
> default to true. Turn off activate_on_mouseover and
> listen_for_mouseover_out quirks for iPhone. Never register for
> onmouseover/out events when listen_for_mouseover_out quirk is false.
>
> embednew.js - Explicitly set lz.browser.is* to false. Add detection
> logic for iPhone, setting isSafari and isIphone to true.
>
> Tests: Hmm, not sure how one would test this without an iPhone.
> Maybe someone has one? I swear, it works for me :). See LPP-6564
> for more details (from quirksmode/ptw) on why I think this is the
> right fix.
>
> Files:
> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M lps/includes/source/embednew.js
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080902-maxcarlson-z.tar
More information about the Laszlo-dev
mailing list