[Laszlo-dev] For Review: 20080903-laszlo-8 Summary: Check in the latest LzPix Mobile into trunk

Philip Romanik promanik at laszlosystems.com
Wed Sep 3 06:55:11 PDT 2008


Approved!

When you make your next pass through the code you have many 
references to this['foo'] that can be this.foo. For example, in 
dataman.lzx, you have lines that look like,

this['errdel'].register(...)

You just created this.errdel so you can say

this.errdel.register(...)






>Change 20080903-laszlo-8 by laszlo at T43-L3XEXMW on 2008-09-03 04:21:13 EDT
>     in /home/laszlo/src/svn/openlaszlo/trunk-ocelot
>     for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: Check in the latest LzPix Mobile into trunk
>
>New Features:
>
>Bugs Fixed: LPP-6915 - Check in the latest LzPix Mobile into trunk
>
>Technical Reviewer: promanik
>QA Reviewer: max
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: This is the latest revision of LzPix Mobile,
>     updated to Eloo's specifications.  (They needed it
>     to work with 4.0.)  David wanted me to check this
>     into trunk.  Many issues have been fixed (see fix
>     version LzPix Mobile, which covers many of the bugs
>     I fixed).  I also cleaned out all the unused files
>     and removed offline functionality.
>
>     While I was getting this all ready to check into
>     trunk, I figured I'd get it working under SWF9.  It
>     does, now, for the most part, with a handful of
>     little issues here and there.  (For instance, for
>     some reason, it's only displaying eight images
>     instead of the nine you get under SWF8 and DHTML.)
>     I'll go through with a QA pass tomorrow and file
>     the various bugs I find.
>
>Tests: Run LzPix Mobile in SWF8, SWF9 and DHTML.  It
>     should now actually function as you'd expect, and
>     compile under each runtime.  Compare it to the
>     unmodified version of LzPix Mobile, which currently
>     barely works the last time I checked.  (e.g. No
>     matter what image you click, it always only selects
>     the first one.)
>
>     (I'm not entirely sure I worked all the SVN stuff
>     right, since I had to do a lot of swapping out of
>     files and directories.  If it doesn't work, let me
>     know and I'll fix it.)
>
>Files:
>M      demos/lzpixmobile/main.lzx
>R      demos/lzpixmobile/lib/library.lzx
>R      demos/lzpixmobile/lib/hintedlayout.lzx
>R      demos/lzpixmobile/lib/navmanager.lzx
>D      demos/lzpixmobile/data
>D      demos/lzpixmobile/data/photodata.lzx
>D      demos/lzpixmobile/data/picts
>D      demos/lzpixmobile/data/picts/pict1.jpg
>D      demos/lzpixmobile/data/picts/pict2.jpg
>D      demos/lzpixmobile/data/picts/pict3.jpg
>D      demos/lzpixmobile/data/picts/pict4.jpg
>D      demos/lzpixmobile/data/picts/pict5.jpg
>D      demos/lzpixmobile/data/picts/pict6.jpg
>D      demos/lzpixmobile/data/picts/pict7.jpg
>D      demos/lzpixmobile/data/picts/pict8.jpg
>D      demos/lzpixmobile/data/offlineimages
>D      demos/lzpixmobile/data/offlineimages/103743757.jpg
>D      demos/lzpixmobile/data/offlineimages/photo1.jpg
>D      demos/lzpixmobile/data/offlineimages/photo2.jpg
>D      demos/lzpixmobile/data/offlineimages/photo3.JPG
>D      demos/lzpixmobile/data/offlineimages/photo4.jpg
>D      demos/lzpixmobile/data/offlineimages/photo5.JPG
>D      demos/lzpixmobile/data/offlineimages/103660493.jpg
>R      demos/lzpixmobile/resources/footer-button-mover.png
>R      demos/lzpixmobile/resources/icon-grid4.png
>R      demos/lzpixmobile/resources/logo.png
>R      demos/lzpixmobile/resources/icon-pageright.png
>R      demos/lzpixmobile/resources/header-button-mup.png
>R      demos/lzpixmobile/resources/hdr-bkgnd.png
>D      demos/lzpixmobile/resources/arrowhelp.png
>R      demos/lzpixmobile/resources/option-button-mdown.png
>R      demos/lzpixmobile/resources/resources.lzx
>R      demos/lzpixmobile/resources/icon-grid9.png
>R      demos/lzpixmobile/resources/taglink_icon2.gif
>R      demos/lzpixmobile/resources/footer-button-separator.png
>R      demos/lzpixmobile/resources/footer-button-mup.png
>A      demos/lzpixmobile/resources/icon-pageup.png
>R      demos/lzpixmobile/resources/option-button-mover.png
>D      demos/lzpixmobile/resources/main.lzx
>R      demos/lzpixmobile/resources/icon-pageleft.png
>R      demos/lzpixmobile/resources/icon-header.png
>R      demos/lzpixmobile/resources/option-button-mup.png
>R      demos/lzpixmobile/resources/taglink_icon.gif
>R      demos/lzpixmobile/resources/footer-button-mdown.png
>R      demos/lzpixmobile/resources/footer-button-bkgnd.png
>A      demos/lzpixmobile/resources/icon-pagedown.png
>R      demos/lzpixmobile/resources/option-bkgnd.png
>R      demos/lzpixmobile/classes/test
>D      demos/lzpixmobile/classes/test/test-dataman.lzx
>R      demos/lzpixmobile/classes/library.lzx
>R      demos/lzpixmobile/classes/dataman.lzx
>D      demos/lzpixmobile/classes/photocollection.lzx
>R      demos/lzpixmobile/classes/search.lzx
>D      demos/lzpixmobile/classes/clipboardinterior.lzx
>R      demos/lzpixmobile/classes/mobilescroller.lzx
>D      demos/lzpixmobile/classes/spinner.lzx
>R      demos/lzpixmobile/classes/buddyicon.lzx
>R      demos/lzpixmobile/classes/md5.js
>R      demos/lzpixmobile/classes/optionsbutton.lzx
>D      demos/lzpixmobile/classes/notes.lzx
>D      demos/lzpixmobile/classes/linkbutton.lzx
>R      demos/lzpixmobile/classes/photo.lzx
>R      demos/lzpixmobile/classes/taglink.lzx
>R      demos/lzpixmobile/classes/footerbutton.lzx
>D      demos/lzpixmobile/classes/draggedphotos.lzx
>D      demos/lzpixmobile/classes/classes.lzx
>D      demos/lzpixmobile/classes/albumlayout.lzx
>D      demos/lzpixmobile/classes/optionsmenuitem.lzx
>D      demos/lzpixmobile/classes/clipboard.lzx
>D      demos/lzpixmobile/classes/pivotlayout.lzx
>D      demos/lzpixmobile/classes/favorites.lzx
>R      demos/lzpixmobile/views/clips.lzx
>R      demos/lzpixmobile/views/photodetails.lzx
>D      demos/lzpixmobile/views/optionsmenu.lzx
>
>Changeset:
><http://svn.openlaszlo.org/openlaszlo/patches/20080903-laszlo-8.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080903-laszlo-8.tar
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080903/19a74b51/attachment.html


More information about the Laszlo-dev mailing list