[Laszlo-dev] For Review: Change 20080902-bargull-2wD Summary: LzMakeLoadSprite cleanup

[Max Carlson]

Approved!

André Bargull wrote:
> Change 20080902-bargull-2wD by bargull at dell--p4--2-53 on 2008-09-02 
> 21:31:23
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: LzMakeLoadSprite cleanup
> 
> New Features:
> 
> Bugs Fixed: LPP-5551 (part 1 - cleanup)
> 
> Technical Reviewer: max
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> As part of LPP-5551, I like to do some code cleanup.
> LzMakeLoadSprite:
> - consistent code-formatting
> - changed LzMakeLoadSprite from function to object
> - removed out commented debug-code
> - removed first* properties, instead call "createLoader" directly
> - removed override of "doReplaceResource" because it was superfluous as 
> "_newrescname" was never defined
> - removed "if (! this.loader)"-check in LzMakeLoadSprite.transform, 
> because it always yield true as there is no "loader"-field defined in 
> LzMakeLoadSprite
> - removed "transformerID", no where referenced in the lfc
> 
> 
> Tests:
> 
> Files:
> M WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080902-bargull-2wD.tar
> 
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org