[Laszlo-dev] For Review: Change 20080902-hqm-w Summary: find and declare globals inside of <import>'ed libraries

[Henry Minsky]

Change 20080902-hqm-w by hqm at badtzmaru.home on 2008-09-02 17:15:55 EDT
     in /Users/hqm/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: find and declare globals inside of <import>'ed libraries

New Features:

Bugs Fixed: LPP-6843

Technical Reviewer: ptw
QA Reviewer: pbr
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

The code which walks the DOM looking for nodes with id attributes was  
only descending into
<library> elements, and ignoring <import> elements.

Note: this is a little bit wrong because it makes the global  
declarations in the main app,
not in the imported library. It seems like we would want global var  
declarations for an imported
library to be in the source file for the library, not for the main  
app. But since everything
is compiled en-masse, I guess it doesn't really matter.


Tests:

test case in bug report no longer gives undefined variable warning,  
test case still works
test/snippets/*


Files:
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
CanvasCompiler.java


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080902-hqm-w.tar