[Laszlo-dev] For Review: Change 20081021-dda-p Summary: Add return type declarations to SWF9 [2nd review]

[Donald Anderson]

Well, I'll file a JIRA on this (and the other items), but I'm also  
confused.

I could change the String functions in LzDatapointer.lzs to return  
undefined
on any new return paths, and revert the smoke testcase.
This is what I did in the first review.  That compiles on all  
runtimes, and allows
the tests to pass unchanged.  I was under the impression that
this was not desirable - you said:
    `undefined` may be undefined in as3, but it is not in js1, so we  
can't rely on that.

On the other hand, 'void 0' is not allowed, it gives a SWF9  
compilation error.

- Don

On Oct 24, 2008, at 1:33 PM, P T Withington wrote:

> On 2008-10-24, at 13:20EDT, Donald Anderson wrote:
>
>>     The 'String returns null' case exposed a bug in test/smoke/ 
>> regression.lzl
>>     where an 'undefined' was expected, changed to a null expected.
>
> This is the main change that I think is potentially wrong.  I am ok  
> with it as a temporary work-around, but would like a p0 bug to  
> revert the test and find the cuplrit.  I think there is a place  
> where you need to relax a return type so you can return (String |  
> void) and return undefined on error.
>
> IWBNI you also filed Jira's for the other TODO's you mention.


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20081024/916ea7a6/attachment.html