[Laszlo-dev] [Laszlo-checkins] r11453 - openlaszlo/trunk/WEB-INF/lps/lfc/controllers

[Donald Anderson]

I generally approach code cleanup the way Tucker suggests.
In changes that affect behaviors, fix bugs, etc. do not make drastic  
changes
to indentation/whitespace.  That is kind to the reviewer.
If appropriate, followup with a separate checkin that only changes  
whitespace -
with no 'actual' changes.

As long as we don't have languages that 'know' whitespace: python,  
Makefile,
having the review script ignore whitespace when generating diffs seems  
like
a better solution.

On Oct 16, 2008, at 4:15 PM, Lou Iorio wrote:

> It's very possible that I misunderstand the issue here, but isn't  
> the problem the way svn tracks
> changes? Our DocBook stuff is a total mess; nearly impossible for  
> humans to read, and easy to fix,
> but I was under the impression that I couldn't fix it because svn  
> tracks changes line by line.
>
>
> On Oct 16, 2008, at 4:05 PM, P T Withington wrote:
>
>> Agreed.  But the 'diff' that gets sent with a review is not as  
>> smart.  Maybe we should just tell the diff to ignore whitespace  
>> too.  Oh, I think we did not originally because there was a lot of  
>> Python in the code base.
>>
>> On 2008-10-16, at 14:36EDT, André Bargull wrote:
>>
>>> Hmm, I'm using WinMerge to inspect my diffs and WinMerge has got  
>>> an option to ignore all whitespace changes. This makes it pretty  
>>> easy for me to focus on real changes.
>>>
>>>
>>>> On 2008-10-15, at 04:37EDT, bargull at openlaszlo.org <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev 
>>>> > wrote:
>>>>
>>>> >/ (And did some work for the all-time favourite LPP-2623.)
>>>> /
>>>> When we did the 'class conversion' Phil intentionally did not re-  
>>>> indent the code to make it easier for reviewers to see what  
>>>> changes  had been made.
>>>>
>>>> I was thinking it would be great to go through the whole code  
>>>> base and  re-indent (with no algorithmic changes) at some point.
>>>>
>>>
>>
>>
>
>


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20081016/14af9a9d/attachment.html