[Laszlo-dev] [Laszlo-checkins] r11453 - openlaszlo/trunk/WEB-INF/lps/lfc/controllers
Lou Iorio
lou at louiorio.com
Thu Oct 16 13:15:55 PDT 2008
It's very possible that I misunderstand the issue here, but isn't the
problem the way svn tracks
changes? Our DocBook stuff is a total mess; nearly impossible for
humans to read, and easy to fix,
but I was under the impression that I couldn't fix it because svn
tracks changes line by line.
On Oct 16, 2008, at 4:05 PM, P T Withington wrote:
> Agreed. But the 'diff' that gets sent with a review is not as
> smart. Maybe we should just tell the diff to ignore whitespace
> too. Oh, I think we did not originally because there was a lot of
> Python in the code base.
>
> On 2008-10-16, at 14:36EDT, André Bargull wrote:
>
>> Hmm, I'm using WinMerge to inspect my diffs and WinMerge has got an
>> option to ignore all whitespace changes. This makes it pretty easy
>> for me to focus on real changes.
>>
>>
>>> On 2008-10-15, at 04:37EDT, bargull at openlaszlo.org <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
>>> > wrote:
>>>
>>> >/ (And did some work for the all-time favourite LPP-2623.)
>>> /
>>> When we did the 'class conversion' Phil intentionally did not re-
>>> indent the code to make it easier for reviewers to see what
>>> changes had been made.
>>>
>>> I was thinking it would be great to go through the whole code base
>>> and re-indent (with no algorithmic changes) at some point.
>>>
>>
>
>
More information about the Laszlo-dev
mailing list