[Laszlo-dev] For Review: 20081010-laszlo-2 Summary: SWF9: Datapointer ActionScript errors when using combobox with datapath

[Philip Romanik]

Your check isn't quite right. The argument is a lz.DataNodeMixin, not 
lz.datapointer.
As Andre mentioned in LPP-7147, the check is

             if(d is lz.DataNodeMixin){

BTW, The use of 'is' instead of 'instanceof' is described here:
http://wiki.openlaszlo.org/SWF9_Conversion#calling_.27instanceof.27_with_a_null_value_will_throw_runtime_error.






>NOTE: This is an update for the Amazon bug from yesterday, which 
>fixes the broader issue.
>
>Change 20081010-laszlo-2 by laszlo at T43-L3XEXMW on 2008-10-10 08:20:18 EDT
>     in /home/laszlo/src/svn/openlaszlo/trunk-bigboss
>     for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: SWF9: Datapointer ActionScript errors when using combobox 
>with datapath
>
>New Features:
>
>Bugs Fixed: LPP-7147 - SWF9: Datapointer ActionScript errors when 
>using combobox with datapath
>
>Technical Reviewer: promanik
>QA Reviewer: henry
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: There was an issue where basecombobox expected
>     that a particular argument would always be a
>     datapointer, but there were many cases in which
>     it wasn't.  So I altered it so that it would only
>     call setPointer() if the argument passed was an
>     instance of a datapointer, to prevent it from
>     trying (and failing) when it was a string.
>
>Tests: Run the Amazon demo in SWF9 (and the other
>     runtimes).  Edit one of the credit cards in
>     payment options.  You shouldn't get any kind
>     of AS error that crashes the app.
>
>     If you want, you could run the testcase from
>     LPP-7147 in SWF9.  There should now be no errors.
>
>     Also, run the combobox tests and examples -- they
>     should all still function the same.
>
>Files:
>M      lps/components/base/basecombobox.lzx
>
>Changeset:
><http://svn.openlaszlo.org/openlaszlo/patches/20081010-laszlo-2.tar>http://svn.openlaszlo.org/openlaszlo/patches/20081010-laszlo-2.tar
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20081010/2c72b460/attachment-0001.html