[Laszlo-dev] Question regarding change at rev. #4714

[André Bargull]

Hi Max,

may you explain why it was necessary to comment the following line in 
"LzMakeLoadSprite.setResource(..)"? This causes an image load failure in 
swf8, you can reproduce the issue with the testcase at LPP-5670 (only 
two of four yellow views are visible in swf8).
In particular, I'm curious why a change in a method which handles 
compiled-in resources, led to a fix for a bug which is about 
runtime-loaded images?


>      -          -         this.loader.attachLoadMovie( nresc );
>      -          -         if ( this.queuedplayaction == null ){
>      -          -             this.queuePlayAction( "checkPlayStatus" );
>      -          -         }
>   4714        max         //this.updateAfterLoad();
>      -          -     }
>      -          - }

> r4714 | max | 2007-04-13 20:27:27 +0200 (Fri, 13 Apr 2007) | 29 lines
> Ge?\195?\164nderte Pfade:
>    M 
> /openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as 
>
>    M 
> /openlaszlo/branches/legals/WEB-INF/lps/lfc/kernel/swf/LzMediaLoader.lzs
>
> Change 20070412-maxcarlson-G by maxcarlson at plastik 
> <mailto:maxcarlson at plastik> on 2007-04-12 20:17:13 PDT
>     in /Users/maxcarlson/openlaszlo/legals-clean
>     for http://svn.openlaszlo.org/openlaszlo/branches/legals
>
> Summary: Fix resourcewidth and height for proxied swf and image loading
>
> New Features:
>
> Bugs Fixed: LPP-3877 <http://www.openlaszlo.org/jira/browse/LPP-3877> 
> - Loading images in proxyless mode can lead to false onload events 
> with resourceheight/width of 0
>
> Technical Reviewer: promanik
> QA Reviewer: jcrowley
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
>
> Tests: See http://jira.openlaszlo.org/jira/browse/LPP-3877. Load 
> http://localhost:8080/legals/my-apps/grigloadswf.lzx and 
> http://localhost:
> 8080/legals/my-apps/grigloadswf.lzx?lzproxied=false after clearing 
> caches. You should see exactly one onload event for each button, with val
> id/nonzero resource width and height. Also reload after or during 
> existing load.
>
> Files:
> M WEB-INF/lps/lfc/kernel/swf/LzMediaLoader.lzs
> M WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20070412-maxcarlson-G.tar