[Laszlo-dev] For Review: Change 20081008-bargull-xEZ Summary: selection state did not update properly

[André Bargull]

So you ask me to look at "LzReplicationManager#detachClone(LzView)",
especially this line of code:
> cl.p = null;

"cl" is a LzView and so line does not make any sense to me,
it should be like that, shouldn't it?
> cl.datapath.p = null;

Testing...

Yes, with "cl.datapath.p = null", the selection works now, too.
I'll update the changeset.



On 10/8/2008 2:04 PM, P T Withington wrote:
> I don't understand how the state of selection of the clone could change 
> if the datapointer of the clone has not changed?  It's clear that your 
> fix works, but I'd like to understand why it works, and expand on your 
> comment in the code so someone (like me) does not optimize it back to 
> not working.
> 
> Is it possible that when a clone is recycled through the clone pool the 
> selected state is reset but its datapointer is not?  If that is how this 
> is happening, it seems the bug really lies there.
> 
> On 2008-10-08, at 05:55EDT, André Bargull wrote:
> 
>> Change 20081008-bargull-xEZ by bargull at dell--p4--2-53 on 2008-10-08 
>> 11:48:04
>> in /home/Admin/src/svn/openlaszlo/trunk
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: selection state did not update properly
>>
>> New Features:
>>
>> Bugs Fixed: LPP-2339
>>
>> Technical Reviewer: ptw
>> QA Reviewer: mamye
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>> The current selection-logic did not account a selection-change if the 
>> data-element didn't change,
>> which might happen for lazy replicated elements. Therefore I've moved 
>> the "setSelected()"-call before
>> the "if(pc)"-block.
>> Additionally moved setter for "datacontrolsvisibility" to property 
>> declaration
>>
>>
>> Tests:
>> see bugreport
>>
>> Files:
>> M WEB-INF/lps/lfc/data/LzDatapath.lzs
>>
>> Changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20081008-bargull-xEZ.tar
>>
>>
> 
>