[Laszlo-dev] For Review: Change 20081001-Philip-8 Summary: Revert onapply event

P T Withington ptw at laszlosystems.com
Thu Oct 2 05:11:29 PDT 2008


I think in the debugger the handlers for 'onapplied' should really be  
'onremove', because there's no sense in preserving the state when you  
start a drag,  only when you stop.  The current code will work, but it  
is inefficient.

Approved.

On 2008-10-01, at 21:21EDT, Philip Romanik wrote:

> Change 20081001-Philip-8 by <mailto:Philip at Philip-DC>Philip at Philip- 
> DC on 2008-10-01 19:46:16 EDT
>    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>    for <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Revert onapply event
>
> New Features:
>
> Bugs Fixed: LPP-6941, LPP-6951
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> To address LPP-6941, any deprecation warning related to  
> LzState#onapply was removed. The doc for onapply is updated and is  
> no longer marked private.
>
> To address LPP-6951, the earlier transformation of onapply ->  
> onapplied was reverted. Andre indicated that /lps/components/ 
> debugger/debugger.lzx needs to be changed, but I don't think this is  
> the case.
>
>
> Tests:
> <http://localhost:8080/trunk/examples/components/window_example.lzx>http://localhost:8080/trunk/examples/components/window_example.lzx 
>  in all platforms
> <http://localhost:8080/trunk/test/smoke/smokecheck.lzx>http://localhost:8080/trunk/test/smoke/smokecheck.lzx 
>  in swf8. (There are errors in dhtml/swf9 but are unrelated)
>
> Files:
> M      WEB-INF/lps/lfc/helpers/LzState.lzs
> M      lps/components/utils/diagnostic/inspector/inspector.lzx
> M      lps/components/base/basewindow.lzx
>
> Changeset: <http://svn.openlaszlo.org/openlaszlo/patches/20081001-Philip-8.tar 
> >http://svn.openlaszlo.org/openlaszlo/patches/20081001-Philip-8.tar



More information about the Laszlo-dev mailing list