[Laszlo-dev] For Review: Change 20081001-hqm-S Summary:, combobox gets error in swf9

[André Bargull]

Not approved.

1. "getNextSubview" returns the next view for a given view/datapointer - 
so item n is selected, item n+1 gets highlighted
2. if you remove the "this._hiliteview['setHilite']"-test, you must add 
this method to baselistitem
    a. "setHilite" was intended as an optional method
    b. and that test also helped to distinguish listitems from 
datapointers (!)
[3. the overall idea to store a highlight view is likely to break for 
lazy replicated views]


Here's the failure due to "getNextSubview".

to reproduce:
- select item "a"
- tab out to button
- tab back to list
- move down-arrow key

expected:
- item "b" is highlighted

actual:
- item "c" is highlighted

testcase:
<canvas>
  <list>
    <textlistitem text="a" />
    <textlistitem text="b" />
    <textlistitem text="c" />
  </list>
  <button x="150" />
</canvas>


> Change 20081001-hqm-S by hqm at badtzmaru.home on 2008-10-01 22:28:30 EDT
>      in /Users/hqm/openlaszlo/trunk
>      for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: combobox gets error in swf9
>
> New Features:
>
> Bugs Fixed: LPP-7057
>
> Technical Reviewer: promanik
> QA Reviewer: mamye
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> + ensure that selection returned by selectionmanager points to a view
>
> The baselist class tries to hilite the current selection, and if the
> replication is 'lazy', the selection manager will return a
> LzDatapointer instead of a view. the method getNextSubview on
> datalistselector is supposed to ensure that a view is returned for the
> currently selected object
>
>
> Tests:
>
> test case from bug report
>
> Files:
> M      lps/components/base/baselist.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081001-hqm-S.tar