[Laszlo-dev] For Review: Change 20081124-bargull-seH Summary: add implementation for text-align, text-indent, text-decoration, letter-spacing

André Bargull andre.bargull at udo.edu
Mon Nov 24 14:25:08 PST 2008


Change 20081124-bargull-seH by bargull at dell--p4--2-53 on 2008-11-24 18:58:03
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: add implementation for text-align, text-indent, 
text-decoration, letter-spacing

New Features: LPP-7385

Bugs Fixed: LPP-7384

Technical Reviewer: max
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
LzText:
- convert "setMultiline()" to setter, deprecate old method
- added "textalign", "textindent", "letterspacing" and "textdecoration"

LzTextSprite (swf8):
- added "_textAlign", "_textIndent", "_letterSpacing", "_textDecoration"
- implemented setters, really straight forward
- update "__setFormat()" to reflect changes in TextFormat
- use "leftMargin" for negative textleading
- use "wordWrap" in "getTextHeight()" instead of setting "_width" to a 
high value
- make sure to back-up dimensions in "getTextfieldHeight()", or the 
textclip's width is no longer in sync with the sprite's width
(this was required for "textalign" to work!)

LzTextSprite (swf9):
- added "textalign", "textindent", "letterspacing" and "textdecoration"
- update "__setFormat()" to reflect changes in TextFormat
- use "leftMargin" for negative textleading
- implemented setters, again pretty straight forward

LzSprite (dhtml):
- added default styles
- removed "letter-spacing" adjustement for 
'text_height_includes_margins'-quirk (LPP-7384)
- added some quirks for IE and Opera

LzTextSprite (dhtml):
- added "_textAlign", "_textIndent", "_letterSpacing", "_textDecoration" 
and "__LZtextIndent"
- updated "getTextSize()" to reflect new attributes
- updated "setWidth()" and "setHeight()" to get the same effect as 
Flash-TextFormat's "leftMargin"
- implemented setters for the new attributes, only needed to special 
case "textindent" to copy "leftMargin" behaviour from Flash



Tests:
run test/text/newtextformat.lzx should look the same in all runtimes 
(tested swf8, swf9, dhtml in FF3, IE6, Opera9.6)

Files:
M WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
M WEB-INF/lps/lfc/views/LzText.lzs
A test/text/newtextformat.lzx

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20081124-bargull-seH.tar




More information about the Laszlo-dev mailing list