[Laszlo-dev] For Review: Change 20081111-ptw-E Summary: LzBootstrapMessage needs to implement the String interface

[André Bargull]

Approved.


On 11/11/2008 8:17 PM, P T Withington wrote:
> Change 20081111-ptw-E by ptw at dueling-banjos.home on 2008-11-11 
> 13:56:20 EST
>     in /Users/ptw/OpenLaszlo/trunk-2
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: LzBootstrapMessage needs to implement the String interface
>
> Bugs Fixed:
> LPP-7316  LzMessage missing substring in non-debug mode?
> LPP-5934  declare public LFC methods and attributes as public (partial)
>
> Technical Reviewer: a.bargull at intensis.de (pending)
> QA Reviewer: etjabberwock at gmail.com (pending)
>
> Details:
>     LzURL, LzMemory, LzFont, LaszloEvent, LzParsedPath,
>     LzMessage:  These are all standalone classes, therefore they
>     should simply declare their `toString` method public, so it will
>     be correctly invoked by `String(...)` and `'' + ...`.
>
>     LzEventable:  For swf9, install `prototype.toString` that
>     trampolines to our private toString method.  This makes all
>     descendants (i.e., nodes) print prettily in swf9 (or at least, as
>     pretty as their toString method, instead of just printing [<class>
>     object]).
>
>     */LzMessage: Move the String interface implementation from the
>     debugger to the boostrap so it is available in all runtimes.
>     Override the important API's that create a new message in the
>     debug version to update the object array.
>
> Tests:
>     smokecheck, test case from LPP-7316 runs in non-debug
>
> Files:
> M      WEB-INF/lps/lfc/services/LzURL.lzs
> M      WEB-INF/lps/lfc/debugger/LzMessage.lzs
> M      WEB-INF/lps/lfc/debugger/LzMemory.lzs
> M      WEB-INF/lps/lfc/core/LzEventable.lzs
> M      WEB-INF/lps/lfc/helpers/LzFont.lzs
> M      WEB-INF/lps/lfc/events/LaszloEvents.lzs
> M      WEB-INF/lps/lfc/data/LzParsedPath.lzs
> M      WEB-INF/lps/lfc/compiler/LzMessage.lzs
>
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20081111-ptw-E.tar
>