[Laszlo-dev] For Review: Change 20081030-laszlo-2 Summary: Color example 3 gives warnings.

J Crowley jcrowley at laszlosystems.com
Sat Nov 1 20:29:33 PDT 2008


Sounds good.  I've already checked this in, but I'll revise as 
recommended and check that in.

P T Withington wrote:
> I agree.  There are 2 ways to specify a color in CSS:  a color name 
> (where the name is one of the 16 css color names), or RGB.  RGB has 3 
> forms:  hex (#0000ff), percent (rgb(0,0,100%)), or numbers in the 
> range 0-255 (rgb(0,0,255)).  It would be nice to show all those 
> possibilities.
>
> We used to allow the kludge of specifying the color as a string that 
> could be parsed as a number ('0x0000ff'), but that is not true CSS, so 
> we have deprecated it.  It was really only a work-around for our 
> incomplete CSS parser.
>
>
> On 2008-11-01, at 13:51EDT, Lou Iorio wrote:
>
>> not approved (I know, you didn't ask)
>>
>> The example still prints:
>>
>> 3=styled by 0x0000FF
>>
>> I think the second declaration should be deleted, not repeated.
>>
>> #vRGB {
>>    bgcolorRGB : "#0000FF";
>>    }
>>
>>    #tRGB {
>>    fgcolorRGB : "#0000FF";
>>    }
>>
>>    #vHex {
>>    bgcolorHex : "#0000FF";
>>    }
>>
>>    #tHex {
>>    fgcolorHex : "#0000FF";
>>    }
>>
>>
>> On Oct 30, 2008, at 5:11 AM, J Crowley wrote:
>>
>>> Change 20081030-laszlo-2 by laszlo at T43-L3XEXMW on 2008-10-30 
>>> 04:58:01 EDT
>>> in /home/laszlo/src/svn/openlaszlo/trunk-liquid
>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Color example 3 gives warnings.
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-7193 - Color example 3 gives warnings.
>>>
>>> Technical Reviewer: max
>>> QA Reviewer: promanik
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details: Fixed the example as the warnings dictated.
>>> (CSS colors can't be of the format 0x000000.)
>>>
>>> Tests: Run the affected file. There should be no
>>> warnings about invalid color formats.
>>>
>>> Files:
>>> M docs/src/developers/programs/color-$3.lzx
>>>
>>> Changeset: 
>>> http://svn.openlaszlo.org/openlaszlo/patches/20081030-laszlo-2.tar
>>>
>>>
>>
>
>




More information about the Laszlo-dev mailing list