[Laszlo-dev] For Review: Change 20080513-bargull-420 Summary: components and debugger updates

[André Bargull]

1) ok, I'll change that
2) yes, it's only because of swf9
3) basescrollbar: LzDelegate is used -> ignore argument is needed
    basegridrow: can be folded in a handler [, resp. must be folded in a 
handler, see gridtext] ("domouseout" and "domouseover")
    gridtext: LzDelegate is used -> ignore argument is needed
   

On 5/16/2008 8:36 PM, P T Withington wrote:
> I have some questions and comments:
>
> 1) You should probably use LzDebugService rather than LzDebugClass.  
> That is our pattern for singletons.  See, for instance, LzIdleService.
>
> 2) Why do you need to say:
>
> -        return (al > bl) - (al < bl);
> +        return ((al > bl)?1:0) - ((al < bl)?1:0);
>
> The comparisons should result in booleans which should coerce to 0/1 
> in a numeric context, so these should yield the same answer, but the 
> compiler would have to be much smarter to optimize your version.  Does 
> swf9 complain?
>
> 3) In the cases where you added the ignore argument for the event 
> contract, is the method really needed, or could it be folded into the 
> body of a handler instead?
>
>
> On 2008-05-13, at 15:04 EDT, André Bargull wrote:
>
>> Change 20080513-bargull-420 by bargull at dell--p4--2-53 on 2008-05-13 
>> 20:06:32
>> in /home/Admin/src/svn/openlaszlo/trunk
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: components and debugger updates
>>
>> New Features:
>>
>> Bugs Fixed: LPP-5955 (partial)
>>
>> Technical Reviewer: ptw
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>> base/basescrollbar: add ignore-argument to match event-contract
>> base/basegridrow: add ignore-arguments to match event-contract
>> layouts/resizelayout: match superclass method signature
>> lz/gridtext: add ignore-argument to match event-contract
>> lz/floatinglist: match superclass method signature
>> debugger/debugger: match superclass method signature, workaround for 
>> swf9 "state-this" bug, update sort-function for swf9
>> debugger/newcontent: match superclass method signature
>> debugger/scrollingtext: match superclass method signature
>> debugger/LzDebug: update sort-function for swf9
>> debugger/swf9stubs: make LzDebug instance of LzDebugClass
>>
>>
>> Tests:
>> After applying the compiler changes listed at LPP-5955, you'll see 
>> new errors, which are covered by this changeset
>>
>>
>> Files:
>> M WEB-INF/lps/lfc/debugger/swf9stubs.lzs
>> M WEB-INF/lps/lfc/debugger/LzDebug.lzs
>> M lps/components/debugger/debugger.lzx
>> M lps/components/debugger/newcontent.lzx
>> M lps/components/debugger/scrollingtext.lzx
>> M lps/components/lz/floatinglist.lzx
>> M lps/components/lz/gridtext.lzx
>> M lps/components/utils/layouts/resizelayout.lzx
>> M lps/components/base/basegridrow.lzx
>> M lps/components/base/basescrollbar.lzx
>>
>> Changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20080513-bargull-420.tar
>>
>>
>>
>
>