[Laszlo-dev] Smokecheck failing for getallresponseheaders? [Was: For Review: Change 20080506-ptw-B Summary: Lazy Replication Doc]

André Bargull a.bargull at intensis.de
Mon May 12 22:48:59 PDT 2008


First thing to do, is to remove the early return statement for 
non-LzMiniNodes in "LzDelegate#register(..)", I guess..


> uh-oh, so I broke something...  I just couldn't stick with fixing the  
> doc, I had to play.  stupid!
>
> On 2008-05-12, at 22:04 EDT, Henry Minsky wrote:
>
> >/ change 9095 is the one where the bug appears. The dataset in the  
> />/ regression
> />/ test
> />/
> />/    <dataset name="bug1315" src="../resources/xml/http.xml" type="http"
> />/ request="true" getresponseheaders="false"/>
> />/
> />/ does not appear to have loaded any data.
> />/
> />/ I can see a HTTP Request get made from the browser,  and it's  
> />/ dataRequest is
> />/ stuck in the "loading" state. So something is preventing the ondata  
> />/ event
> />/ from being sent, or preventing the dataset from getting it's setData()
> />/ method called.
> />/
> />/
> />/ On Mon, May 12, 2008 at 8:55 PM, Henry Minsky <henry.minsky at gmail.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev>>
> />/ wrote:
> />/
> />>/ Hmm, I rearranged the inheritance for LzDataElement and LzDataText,  
> />>/ I'll
> />>/ see if I can find which
> />>/ changeset caused smokecheck to fail.
> />>/
> />>/
> />>/ On Mon, May 12, 2008 at 8:34 PM, P T Withington <ptw at laszlosystems.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev> 
> />>/ >
> />>/ wrote:
> />>/
> />>>/ You were just playing with dataset, no?
> />>>/
> />>>/ On 2008-05-12, at 20:12 EDT, Philip Romanik wrote:
> />>>/
> />>>/ Approved!
> />>>>/
> />>>>/ smoketest fails in swf, but I'm not sure if it is this change or
> />>>>/ another one from today:
> />>>>/
> />>>>/ Tests: 870 Failures: 1 Errors: 1
> />>>>/ TestFailure: $lzc$class_bug_1315 >>> testRespHeaders failed:  
> />>>>/ Equals:
> />>>>/ expected '' got «undefined»
> />>>>/ TestError: $lzc$class_bug_1315 >>> testRespHeaders failed: call to
> />>>>/ undefined method 'toString'
> />>>>/
> />>>>/
> />>>>/ [Phil, I'm just asking that you verify the resize replication  
> />>>>/ manager
> />>>>>/ example works now -- since you were the last one in the area,  
> />>>>>/ and you
> />>>>>/ wondered how it would work in swf9, I think this solution should  
> />>>>>/ be
> />>>>>/ portable.
> />>>>>/
> />>>>>/ Lou, Mamye: I am checking this in so you can verify with the  
> />>>>>/ nightly
> />>>>>/ (or your own) build.]
> />>>>>/
> />>>>>/ Change 20080506-ptw-B by <mailto:ptw at dueling-banjos.local <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev>
> />>>>>>/ ptw at dueling-banjos.local <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev> on 2008-05-06
> />>>>>/ 06:57:02 EDT
> />>>>>/   in /Users/ptw/OpenLaszlo/ringding-2
> />>>>>/   for <http://svn.openlaszlo.org/openlaszlo/trunk>
> />>>>>/ http://svn.openlaszlo.org/openlaszlo/trunk
> />>>>>/
> />>>>>/ Summary: Lazy Replication Doc
> />>>>>/
> />>>>>/ Bugs Fixed:
> />>>>>/ LPP-1982 'Spacing attribute on datapath'
> />>>>>/ LPP-5986 'Resize replication example no longer works'
> />>>>>/
> />>>>>/ Technical Reviewer: promanik (pending)
> />>>>>/ QA Reviewer: mamye (pending)
> />>>>>/ Doc Reviewer: liorio (pending)
> />>>>>/
> />>>>>/ Details:
> />>>>>/   regression: Add event handler to avoid warning
> />>>>>/
> />>>>>/   LzGlobalMouse: Make example work.  Document all the events.  Add
> />>>>>/   global alias.
> />>>>>/
> />>>>>/   LzMiniNode, LzNode, LzIdle:  _events is part of the mini-node
> />>>>>/   protocol (used by LzEvent).
> />>>>>/
> />>>>>/   LaszloEvents: Clean up redundant debug information.  Document
> />>>>>/ that
> />>>>>/   event senders and recipients must be a subclass of LzMiniNode.
> />>>>>/
> />>>>>/   LzReplicationManager: Clean up documentation, give types and
> />>>>>/   description to attributes and events.  Silence warnings for
> />>>>>/   calling setVisible on clones.
> />>>>>/
> />>>>>/   LzLazyReplicationManager:  Clean up documentation,  give types
> />>>>>/ and
> />>>>>/   description to attributes.
> />>>>>/
> />>>>>/   LzDatapointer: Mark internal properties as private
> />>>>>/
> />>>>>/   LzResizeReplicationManager:  Make this work again.  Clean up
> />>>>>/   documentation.
> />>>>>/
> />>>>>/   LzDatapointer: Cleaned up documentation.  Eliminated uneccesary
> />>>>>/   trampoline for setting __LZmanager property.
> />>>>>/
> />>>>>/ Tests:
> />>>>>/   Built doc, visually inspected, verified resize replication
> />>>>>/ example
> />>>>>/   works, ant lztest, smokecheck.
> />>>>>/
> />>>>>/ Files:
> />>>>>/ M      test/smoke/regression.lzl
> />>>>>/ M      WEB-INF/lps/lfc/services/LzGlobalMouse.lzs
> />>>>>/ M      WEB-INF/lps/lfc/services/LzIdle.lzs
> />>>>>/ M      WEB-INF/lps/lfc/core/LzMiniNode.lzs
> />>>>>/ M      WEB-INF/lps/lfc/core/LzNode.lzs
> />>>>>/ M      WEB-INF/lps/lfc/events/LaszloEvents.lzs
> />>>>>/ M      WEB-INF/lps/lfc/data/LzReplicationManager.lzs
> />>>>>/ M      WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs
> />>>>>/ M      WEB-INF/lps/lfc/data/LzDatapointer.lzs
> />>>>>/ M      WEB-INF/lps/lfc/data/LzResizeReplicationManager.lzs
> />>>>>/ M      WEB-INF/lps/lfc/data/LzDatapath.lzs
> />>>>>/
> />>>>>/
> />>>>>/ Changeset: <
> />>>>>/ http://svn.openlaszlo.org/openlaszlo/patches/20080506-ptw-B.tar>
> />>>>>/ http://svn.openlaszlo.org/openlaszlo/patches/20080506-ptw-B.tar
> />>>>>/
> />>>>/
> />>>/
> />>/
> />>/
> />>/ --
> />>/ Henry Minsky
> />>/ Software Architect
> />>/ hminsky at laszlosystems.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev>
> />>/
> />>/
> />/
> />/
> />/ -- 
> />/ Henry Minsky
> />/ Software Architect
> />/ hminsky at laszlosystems.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev>
> /


More information about the Laszlo-dev mailing list