[Laszlo-dev] [JIRA] Assigned: (LPP-5930) RTMP: API-change, rename "call" method

[P T Withington]

Yeah, as soon as you update the schema parser to accept it.  :)

That's my proposed syntax.  I haven't done anything to actually  
implement it...  If you think we need it sooner than later, I guess  
you should file an improvement request.

On 2008-05-05, at 09:26 EDT, Henry Minsky wrote:

> So that syntax would allow you to declare static class methods on
> user-defined LZX classes?
>
>
> On Mon, May 5, 2008 at 9:00 AM, P T Withington <ptw at laszlosystems.com>
> wrote:
>
>> That would be fine if you had a way to make the _static_ methods  
>> final.
>> Call and apply are built-ins on the _class_, not on instances of  
>> the class.
>> If you want to make the schema smarter, my proposal is that we add a
>> property to methods and attributes of LZX classes called  
>> `allocation`, so
>> you would say:
>>
>> <class Instance>
>> <method name="call" allocation="class" final="true" />
>> <method name="apply" allocation="class" final="true" />
>> ...
>>
>>
>> On 2008-05-05, at 00:40 EDT, Henry Minsky wrote:
>>
>> I thought I was being smart by declaring "call" and "apply" as being
>>> final,
>>> so that the compiler
>>> would complain at people if they tried to override them, because I
>>> figured
>>> people would do
>>> that accidentally and then something that expected apply or call  
>>> to work
>>> would break. But
>>> maybe that was the wrong thing to do. Should we just assume the user
>>> knows
>>> what they
>>> are doing if they override these? I guess that's where having to  
>>> specify
>>> override explicitly
>>> is useful, kind of like a little liability waiver for the  
>>> developer to
>>> sign
>>> when they redefine a method...
>>>
>>>
>>>
>>> On Sun, May 4, 2008 at 1:30 PM, P T Withington (JIRA) <
>>> jira at laszlosystems.com> wrote:
>>>
>>>
>>>>  [
>>>>
>>>> http://www.openlaszlo.org/jira/browse/LPP-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>> ]
>>>>
>>>> P T Withington reassigned LPP-5930:
>>>> -----------------------------------
>>>>
>>>> Assignee: Henry Minsky  (was: Sarah Allen)
>>>>
>>>> Assigning to Henry.  We should fix the schema to be accurate.
>>>>
>>>> RTMP: API-change, rename "call" method
>>>>> --------------------------------------
>>>>>
>>>>>              Key: LPP-5930
>>>>>              URL: http://www.openlaszlo.org/jira/browse/LPP-5930
>>>>>          Project: OpenLaszlo
>>>>>       Issue Type: Bug
>>>>>       Components: Extensions - Streaming Audio / Video
>>>>> Affects Versions: RingDing
>>>>>         Reporter: André Bargull
>>>>>         Assignee: Henry Minsky
>>>>>
>>>>> From laszlo-user ("
>>>>>
>>>> http://www.openlaszlo.org/pipermail/laszlo-user/2008-May/
>>>> 006752.html"):
>>>>
>>>>> I recently ran a lzx test app in 4.0.12 that makes a call to Red5.
>>>>>>
>>>>> What
>>>>
>>>>> worked fine in an previous laszlo versions
>>>>>> has since stopped working.  This time, however, I am seeing the
>>>>>>
>>>>> following
>>>>
>>>>> compiler warnings:
>>>>>> *extensions/av/rtmpconnection.lzx:14:49:* Method
>>>>>> rtmpconnection.call
>>>>>>
>>>>> is
>>>>
>>>>> overriding a superclass method of the same name which has been
>>>>>>
>>>>> declared
>>>>
>>>>> non-overridable
>>>>>> *extensions/av/rtmpconnection.lzx:250:48:* Method
>>>>>> netremotecall.call
>>>>>>
>>>>> is
>>>>
>>>>> overriding a superclass method of the same name which has been
>>>>>>
>>>>> declared
>>>>
>>>>> non-overridable
>>>>>>
>>>>> Henry's response ("
>>>>>
>>>> http://www.openlaszlo.org/pipermail/laszlo-user/2008-May/
>>>> 006755.html"):
>>>>
>>>>> Hmm, we rewrote how the base "schema" is declared to the compiler,
>>>>>> and
>>>>>>
>>>>> that
>>>>
>>>>> does indeed declare "call" as a final method:
>>>>>> [....]
>>>>>> Since 'call' is a javascript built-in, it would really be best to
>>>>>>
>>>>> rename
>>>>
>>>>> this method in the library.
>>>>>>
>>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> -
>>>> If you think it was sent incorrectly contact one of the
>>>> administrators:
>>>> http://www.openlaszlo.org/jira/secure/Administrators.jspa
>>>> -
>>>> For more information on JIRA, see:
>>>> http://www.atlassian.com/software/jira
>>>>
>>>>
>>>>
>>>>
>>>
>>> --
>>> Henry Minsky
>>> Software Architect
>>> hminsky at laszlosystems.com
>>>
>>
>>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com