[Laszlo-dev] For Review: Change 20080502-maxcarlson-w Summary: Remodularize LzHistory, fix LzHistory docs.

[Philip Romanik]

Approved, but there are two issues:


1. Shouldn't LzTrackClass be renamed LzTrackService and a comment 
added to where the singleton is instantiated:

/**
   * LzTrack is a shortcut for <a 
href="LzTrackService.html">LzTrackService</a>.
   */


2. The lzhistory.lzx test fails in various ways in swf9. This is 
expected because LzBrowserKernel is missing some functionality. One 
error upon loading is (I think this is the check for 
LzView.prototype.capabilities.persistence):

TypeError: Error #1010: A term is undefined and has no properties.
         at LzHistoryService/setPersist()[C:\Documents and 
Settings\Philip\Local Settings\Temp\lzswf9\lzgen43837\LzHistoryService.as:129]
         at <anonymous>()[C:\Program Files\Apache Software 
Foundation\Tomcat 5.0\temp\lzswf9\lzgen7150\LzApplication.as:18]
         at Function/http://adobe.com/AS3/2006/builtin::call()
         at LzEvent/sendEvent()[C:\Documents and 
Settings\Philip\Local Settings\Temp\lzswf9\lzgen43837\LzEvent.as:49]
         at LzCanvas/__LZcallInit()[C:\Documents and 
Settings\Philip\Local Settings\Temp\lzswf9\lzgen43837\LzCanvas.as:222]
         at LzCanvas/__LZinstantiationDone()[C:\Documents and 
Settings\Philip\Local Settings\Temp\lzswf9\lzgen43837\LzCanvas.as:182]
         at LzInstantiatorService/makeSomeViews()[C:\Documents and 
Settings\Philip\Local 
Settings\Temp\lzswf9\lzgen43837\LzInstantiatorService.as:111]
         at LzInstantiatorService/checkQ()[C:\Documents and 
Settings\Philip\Local 
Settings\Temp\lzswf9\lzgen43837\LzInstantiatorService.as:79]
         at Function/http://adobe.com/AS3/2006/builtin::call()
         at LzEvent/sendEvent()[C:\Documents and 
Settings\Philip\Local Settings\Temp\lzswf9\lzgen43837\LzEvent.as:49]
         at LzIdleClass/__idleupdate()[C:\Documents and 
Settings\Philip\Local Settings\Temp\lzswf9\lzgen43837\LzIdleClass.as:35]
         at LzIdleKernel$/__update()[C:\Documents and 
Settings\Philip\Local Settings\Temp\lzswf9\lzgen43837\LzIdleKernel.as:26]
         at Function/http://adobe.com/AS3/2006/builtin::apply()
         at <anonymous>()
         at SetIntervalTimer/onTimer()
         at flash.utils::Timer/_timerDispatch()
         at flash.utils::Timer/tick()


>Change 20080502-maxcarlson-w by maxcarlson at Roboto on 2008-05-02
>14:16:21 PDT
>      in /Users/maxcarlson/openlaszlo/trunk-clean
>      for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: Remodularize LzHistory, fix LzHistory docs.
>
>New Features:
>
>Bugs Fixed: LPP-5558 - LzHistory (swf7 swf8 swf9) reference page 
>problems, LPP-5557 - LzHistory (dhtml) reference page problems
>
>Technical Reviewer: promanik
>QA Reviewer: hminsky
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: swf/LzBrowserKernel.lzs - Move/implement 
>getPersistedObject(), receivedHistory(), setHistory() and 
>callMethod() APIs from platform/swf/LzHistory.as.
>
>swf/LzSprite.as - Set persistence capability to true, set 
>LzHistory.isReady to true after callbacks are ready.
>
>dhtml/LzSprite.js -  Set persistence capability to false, set 
>LzHistory.isReady to true after callbacks are ready.
>
>dhtml/LzBrowserKernel.lzs - Fix loadJS() to call loadURL() in the 
>correct scope.  Move/implement receivedHistory(), setHistory() and
>callMethod() APIs from platform/dhtml/LzHistory.js.
>
>swf9/LzBrowserKernel.lzs - Add  getPersistedObject(), 
>receivedHistory(), setHistory() and callMethod() APIs from platform/ 
>swf/LzHistory.as.
>
>swf9/LzSprite.as - Set persistence capability to true.
>
>LzTrack.lzs - Fix broken initialization of LzTrack.
>
>Remove old platform-specific LzHistory implementations.
>
>LzKeys.lzs - Change from a static to a service class, move extra 
>keyCode definitions to constructor to make swf9 happy.  Add LzKeys 
>declaration with docs.
>
>Library.lzs - Use the shared LzHistory class for all runtimes.
>
>LzHistory.lzs - Move from swf/LzHistory.as, change from a static to a
>service class, delegate platform-specific parts to LzBrowserKernel.
>Add/update docs.  Add LzHistory declaration with docs.
>
>toc.xml - Update toc to point to LzIdle, LzModeManager, LzTimer and 
>LzHistory entries to point to shortcut declarations.  Use shared 
>LzHistory docs.
>
>lzhistory.js - Use LzHistory.isReady flag to decide when to start 
>sending history messages.
>
>
>Tests: cd docs/src;ant reference; produces correct docs.  /test/ 
>history/history.lzx passes for swf7, 8 and dhtml.  test/lfc/legals/ 
>keyboardandmouse.lzx passes for dhtml, swf8 and swf9.
>
>Files:
>M      WEB-INF/lps/lfc/kernel/swf/LzBrowserKernel.lzs
>M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
>M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>M      WEB-INF/lps/lfc/kernel/dhtml/LzBrowserKernel.lzs
>M      WEB-INF/lps/lfc/kernel/swf9/LzBrowserKernel.lzs
>M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
>M      WEB-INF/lps/lfc/services/LzTrack.lzs
>D      WEB-INF/lps/lfc/services/platform/swf/LzHistory.as
>D      WEB-INF/lps/lfc/services/platform/dhtml/LzHistory.js
>M      WEB-INF/lps/lfc/services/LzKeys.lzs
>M      WEB-INF/lps/lfc/services/Library.lzs
>A  +   WEB-INF/lps/lfc/services/LzHistory.lzs
>M      docs/src/nav/toc.xml
>M      lps/includes/source/lzhistory.js
>
>Changeset: 
><http://svn.openlaszlo.org/openlaszlo/patches/20080502-maxcarlson-w.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080502-maxcarlson-w.tar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080502/97337ab2/attachment.html