[Laszlo-dev] For Review: Change 20080501-maxcarlson-Z Summary: Remodularize platform-specific parts of LzModeManager

[Philip Romanik]

Approved. I did manage to get a swf9 error running modeexample.lzx

ArgumentError: Error #1063: Argument count mismatch on 
$lzc$class_text_$modeexample$2Elzx_195_54/cleartext(). Expected 0, got 1.
         at Function/http://adobe.com/AS3/2006/builtin::call()
         at LzDelegate/execute()[C:\Documents and 
Settings\Philip\Local Settings\Temp\lzswf9\lzgen40802\LzDelegate.as:27]
         at <anonymous>()[C:\Documents and Settings\Philip\Local 
Settings\Temp\lzswf9\lzgen40802\LzTimerClass.as:13]
         at Function/http://adobe.com/AS3/2006/builtin::apply()
         at <anonymous>()
         at SetIntervalTimer/onTimer()
         at flash.utils::Timer/_timerDispatch()
         at flash.utils::Timer/tick()


>Change 20080501-maxcarlson-Z by maxcarlson at Roboto on 2008-05-01
>19:33:39 PDT
>      in /Users/maxcarlson/openlaszlo/trunk
>      for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: Remodularize platform-specific parts of LzModeManager
>
>New Features:
>
>Bugs Fixed: LPP-5912 - Handle LzModeManager Singleton Doc Issues
>
>Technical Reviewer: promanik
>QA Reviewer: hminsky
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: swf/LzMouseKernel.as - Move click stream processing code 
>from platform/swf/LzModeManager.as.  Change __mouseEvent() to
>handleMouseEvent() to comply with the old API in SWFFile.java.
>
>swf/LzInputTextSprite.as - Fix typo where getText() was being 
>assigned to LzTextSprite.  Add findSelection() implementation from 
>platform/swf/ LzModeManager.as
>
>dhtml/LzSprite.js - Call LzMouseKernel.__sendEvent() instead of 
>calling LzModeManager.handleMouseButton() directly.
>
>dhtml/LzMouseKernel.js - Add __sendEvent() API to be used by sprites 
>to send events into the runtime.
>
>dhtml/LzInputTextSprite.js - Add findSelection() implementation from 
>platform/dhtml/LzModeManager.js
>
>swf9/LzMouseKernel.as -  Add __sendEvent() API to be used by sprites 
>to send events into the runtime.  Send global mouse events through
>__sendEvent() instead of directly to LzGlobalMouse.
>
>swf9/LzInputTextSprite.as - Add dummy findSelection() implementation.
>
>delete unused platform/*/LzModeManager files
>
>services/LzModeManager.lzs - __findInputtextSelection() delegates to 
>LzInputTextSprite.findSelection().  Receive all mouse events from 
>the kernel through a single API, rawMouseEvent().  Unify 
>documentation for LzModeManager and callback registration.
>
>services/Library.lzs - Remove unused platform/*/LzModeManager includes
>
>SWFFile.java - Change movieclips to call LzMouseKernel APIs for swf7/8.
>
>Tests: trunk/examples/modeexample.lzx passes in swf8, swf9 and dhtml.
>test/lfc/legals/keyboardandmouse.lzx
>
>Files:
>M      WEB-INF/lps/lfc/kernel/swf/LzMouseKernel.as
>M      WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as
>M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>M      WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
>M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
>M      WEB-INF/lps/lfc/kernel/swf9/LzMouseKernel.as
>M      WEB-INF/lps/lfc/kernel/swf9/LzInputTextSprite.as
>M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
>D      WEB-INF/lps/lfc/services/platform/swf/LzModeManager.as
>D      WEB-INF/lps/lfc/services/platform/dhtml/LzModeManager.js
>D      WEB-INF/lps/lfc/services/platform/swf9/LzModeManager.js
>M      WEB-INF/lps/lfc/services/LzModeManager.lzs
>M      WEB-INF/lps/lfc/services/Library.lzs
>M      WEB-INF/lps/server/src/org/openlaszlo/compiler/SWFFile.java
>
>Changeset: 
><http://svn.openlaszlo.org/openlaszlo/patches/20080501-maxcarlson-Z.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080501-maxcarlson-Z.tar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080502/b4108f59/attachment-0001.html