[Laszlo-dev] For Review: Change 20080430-hqm-w Summary: changes to get lzpix to compile

[P T Withington]

Approved.

But please file Jira Bugs for each of these issues you raise:

1)
> note: I had to add these instance vars:
>  var __LZdeferDelegates = false;
>  var __LZdeleted = false;

It sounds like we should move __LZdeferDelegates and __LZdeleted up to  
LzMiniNode (should that be called DOMNode or something?) and say that  
the first argument to LzDelegate has to be an LzMiniNode.  Delegates  
and Events have more of a protocol now than they used to.

2)
> + Needed to make the "ignore" arg to the binder function and  
> optional arg, for somer reason.
> Maybe we should look at what code is being compiled to call this  
> with no args.

This is surely a bug that we need to track down.  The binder protocol  
is totally internal, so there should not be any need of an optional  
argument -- the contract between the caller and callee is fixed.

3)
> Note: we ought to rename the "stop" method defined in there as it  
> conflicts with the LzView.stop() method

Perhaps assign to Josh?

On 2008-04-30, at 19:24 EDT, Henry Minsky wrote:

> Change 20080430-hqm-w by hqm at badtzmaru.home on 2008-04-30 19:10:59 EDT
>    in /Users/hqm/openlaszlo/trunk5
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: changes to get lzpix to compile
>
> New Features:
>
> Bugs Fixed:
>
> Technical Reviewer: ptw
> QA Reviewer: max
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
>
> + make services/LzTrack.lzs compile in the swf9 LFC
>
> note: I had to add these instance vars:
>  var __LZdeferDelegates = false;
>  var __LZdeleted = false;
> because sendEvent was expecting to be able to access them when
> sending and event to LzTrack
>
>
>
>
> + add LzNode-compatible constructors to LzSelectionManager and  
> LzDataSelectionManager
>
> + removed what looks like an unused var erronesouly being cast to  
> LzView in LzAnimatorGroup
>
> + Needed to make the "ignore" arg to the binder function and  
> optional arg, for somer reason.
> Maybe we should look at what code is being compiled to call this  
> with no args.
>
>
> + fix up various layout methods to take optional args if they can be  
> called by event handlers
>
> + app.lzx: fix up various callers that were too few args
> Note: we ought to rename the "stop" method defined in there as it  
> conflicts with the LzView.stop() method
>
> + demos/lzpix/classes/photo.lzx
> add some missing var declarations
> + ditto  demos/lzpix/classes/draggedphotos.lzx
>
>
>
>
> Tests:
>
> Files:
> M      WEB-INF/lps/lfc/services/LzTrack.lzs
> M      WEB-INF/lps/lfc/services/Library.lzs
> M      WEB-INF/lps/lfc/core/dummyclasses.js
> M      WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
> M      WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
> M      WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> M      lps/components/utils/layouts/stableborderlayout.lzx
> M      demos/lzpix/app.lzx
> M      demos/lzpix/classes/search.lzx
> M      demos/lzpix/classes/dataman.lzx
> M      demos/lzpix/classes/clipboardinterior.lzx
> M      demos/lzpix/classes/md5.js
> M      demos/lzpix/classes/photo.lzx
> M      demos/lzpix/classes/draggedphotos.lzx
> M      demos/lzpix/classes/classes.lzx
> M      demos/lzpix/classes/albumlayout.lzx
> M      demos/lzpix/classes/pivotlayout.lzx
> M      demos/lzpix/classes/clipboard.lzx
> M      demos/lzpix/classes/favorites.lzx
> M      demos/lzpix/views/tools.lzx
> M      demos/lzpix/views/mybutton.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080430-hqm-w.tar