[Laszlo-dev] For Review: Change 20080327-dda-Z Summary: SWF9: remove check to prevent classes beginning with '$'

[Donald Anderson]

Just got back to trying this.
I was able to create a <class name="$...."> and a <method  
name="$...."> without error.
Perhaps it didn't conflict with a name from the tag compiler, but  
since the script
compiler also generates names starting with '$', couldn't this expose  
problems?

On Mar 27, 2008, at 3:49 PM, P T Withington wrote:

> I think the tag compiler is already making such a check.  When it  
> defines a global $lzc... it puts it in the compiler env which is  
> used to check all global names that user tags define (id's, top- 
> level names).  You can try a test if you like.
>
> I approve your change removing this from the swf9 back end though.
>
> On 2008-03-27, at 15:16 EDT, Donald Anderson wrote:
>> Change 20080327-dda-Z by dda at lester.local on 2008-03-27 15:02:15 EDT
>>   in /Users/dda/laszlo/src/svn/openlaszlo/trunk-a/WEB-INF/lps/ 
>> server/src/org/openlaszlo/sc
>>   for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc
>>
>> Summary: SWF9: remove check to prevent classes beginning with '$'
>>
>> New Features:
>>
>> Bugs Fixed: LPP-5677 (partial)
>>
>> Technical Reviewer: ptw (pending)
>> QA Reviewer: hminsky (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>>   Removed a check for class names in SWF9 that is too stringent in  
>> the new world.
>>   Some classes are generated internally starting with '$', and all
>>   we really want to prevent are user classes named this way.
>>   This is to prevent collisions with our own namespace.  The
>>   proper place for this check would seem to be the tag compiler.
>>
>> Tests:
>>   smokecheck swf8/dhtml
>>   henry's hello swf9
>>   henry's little class test that showed this error (gets further,  
>> anyway).
>>
>> Files:
>> M      SWF9Generator.java
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080327-dda-Z.tar
>>
>>
>>
>> --
>>
>> Don Anderson
>> Java/C/C++, Berkeley DB, systems consultant
>>
>> voice: 617-547-7881
>> email: dda at ddanderson.com
>> www: http://www.ddanderson.com
>>
>>
>>
>>
>


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com